New live preview/editing feature locks files forever

[schiessle]

New live preview/editing feature locks files forever

[juliushaertl]

In addition Joas mentioned that Christoph also had issues with text grabbing the focus.

Regarding locking this is nothing we can change short term, we have discussed approaches with only locking a file as soon as there are some actual edits, but this is a technically challenging implementation effort and not feasible.

@jancborchardt I would see making the text editor a read only by default with a button to start editing the only feasible option to have a reasonably good experience. We can work on individual issues then mid-term to at some point bring back editable by default interactive widgets, but this seems to be too heavy for now.

[nickvergessen]

I think we need to have a way to decide if someone really edits the embedded document. Maybe the document should be opened and displayed by default in a read-only mode and only if people click on "edit" the file gets locked. If the keyboard focus leaves the embedded editor, the lock should be removed and the chat view switches back to read-only.

Exactly my feelings about the feature, but unfortunately there is no option for this atm.
Anyway this is nothing Talk can fix. Not sure if it should be moved to Text or the Vue lib. Will ping others for clarification

[AndyScherzinger]

@jancborchardt I would see making the text editor a read only by default with a button to start editing the only feasible option to have a reasonably good experience. We can work on individual issues then mid-term to at some point bring back editable by default interactive widgets, but this seems to be too heavy for now.

@juliushaertl @jancborchardt can we please do exactly this and have this for the release of 29? There isn't just an issue with locking, there is also the focus steal issue - you simply can't chat before all interactive widgets for editable fields are loaded since they keep stealing the cursor - I tried to write a message to marketing and just couldn't for nearly a minute, since while typing in the chat field, the cursor kept jumping into widgets. Given in many cases you might have more than one of those widgets loading you can't really edit them at once anyways.

[schiessle]

Please also keep in mind that the same issue most likely also exists for Office documents. Just want to highlight it once more because the ticket is now now in the "text" repository.

[AndyScherzinger]

Good point, @juliushaertl can you "duplicate" the issue for richdocuments too please? Thanks in advance