ConcurrentModificationException Minecraft Crash.

[0xE69]

ConcurrentModificationException Minecraft Crash.

[0xE69]

The issue in the code is likely occurring in the apply method. If an animation is not alive during the apply method, it's not removed from the queue. If an animation becomes not alive during its apply method (which might be called from another thread), it could cause a ConcurrentModificationException.

GitHub\crafting-dead\crafting-dead-core\src\main\java\com\craftingdead\core\client\animation\AnimationController.java

To fix this, we can use an Iterator in the apply method, similar to how you used it in the tick method. Changes recommended;

    for (var animation : this.animations) {
      if (animation.isAlive()) {
        animation.apply(partialTicks, poseStack);
      }
    }
  }

Change to:

    var iterator = this.animations.iterator();
    while (iterator.hasNext()) {
        var animation = iterator.next();
        if (animation.isAlive()) {
            animation.apply(partialTicks, poseStack);
        } else {
            iterator.remove();
        }
    }
}

This way, if an animation is not alive, it will be safely removed from the queue.

[0xE69]

6bc51ca

Review requested.