Comments (9)
I completely agree it would be over-engineered. But comparatively updating the CODEOWNERS looks easy now.
I really prefer the "native" notification over something else we have to maintain. I think we might be better off expanding the contributing guidelines, and it might just be something we have to do when someone makes a new PR.
A basic list:
main.nf
functions.nf
meta.yml
(With all the documentation)tests/software/main.nf
tests/software/test.yml
.github/workflow/software.yml
- Add a line to CODEOWNERS
I guess at that point I think adding a single line isn't moving the barrier to entry much higher in my opinion.
from modules.
See https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/about-code-owners for docs
from modules.
Just catching up with this but is it not something we can get from the meta.yml
files that are shipped with the module files? I am getting slightly edgy about having to update various files in the repo when adding a module.
from modules.
I don't think we can parse files in meta.yml
or in the CODEOWNERS
file. I also don't think this has to be updated, just like that a meta.yml
isn't a requirement. For example if you're just throwing one in from rnaseq. But someone who's making a PR for a module, it might be nice to have them get pinged on any requests for changes to that module.
from modules.
Why can't we parse the meta.yml
? That is the eventual plan. meta.yml
should be a requirement! 😅
I see every PR on every repo on nf-core all of the time 👀 Save yourself!!
from modules.
I meant just parse it with some bash magic in the CODEOWNERS
wasn't a possibility. But now you've got me dreaming.
We can make a github workflow, that parses all the meta.yaml files, and whenever a change occurs in one of them, it checks for any changes in the owners, and regenerates the CODEOWNERS file if necessary. For a bonus, it might fail if a module doesn't have a meta
file 😛
from modules.
That sounds overly complicated... If we parse the meta file anyway, we can also let the "nf core bot" ping the maintainers. That's how it's done in bioconda.
I have to say that I find it quite elegant that CODEOWNERS "natively" notifies people without having us to mess with bots, but I am also wary about having to update too many different places.
from modules.
https://github.com/milin/gitown This might keep it up to date magically.
from modules.
Hi there!
We’ve noticed there hasn’t been much activity here. Are you still planning on working on this?
If not, you can ignore this message and we’ll close your issue in about 2 weeks.
If you think this is still relevant, you can also add it to the hackathon2023 project board.
Cheers
the nf-core maintainers
from modules.
Related Issues (20)
- Investigate issue extracting minigut_cf.tar.gz for centrifuge
- Investigate issue extracting data.tar.gz for rgi related modules HOT 1
- Investigate unknown issue for checkv/updatedatabase module
- new module: pypgx/createinputvcf
- Fix malt tests that are using a 739.0 MiB zip as input HOT 7
- new module: pypgx/preparedepthofcoverage
- new module: pypgx/computecontrolstatistics
- new module: pypgx/runngspipeline
- Remove tags.yml files if we are sure we no longer need them HOT 1
- new module: MSISENSORPRO/MSISENSORPRO_SOMATIC_TUMORONLY
- Investigate why `subworkflows/nf-core/fastq_align_hisat2` tests were not triggered
- snpeff security issue HOT 3
- [FEATURE] add stub and tests to lofreq/filter
- new module: SENTIEON/QUALCAL
- Standardized channel output for different files HOT 1
- new module: DIAMOND/CLUSTER
- new module: REPEATMASKER HOT 2
- new module: BRAKER3 HOT 1
- update module: FCS/FCSGX
- Minor bug: krakentools/combinekreports incorrect description
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from modules.