Comments (3)
When changing the title, this shouldn't have any bearing on whether meta changes or not. I need to do a quick test to double-check.
from react-helmet.
Any luck?
from react-helmet.
@AmrARaouf
Thanks for your patience.
The reason this fails is because the shouldComponentUpdate
check in Helmet returns false when just passing the meta, which causes the component not to re-render. You would get the same result if you passed an unchanged title value.
I did some debugging and found that in your scenario, when Helmet checks this.props
and nextProps
and compares them, the value is already changed:
[{"name": "keywords", "content": "bar"}, {"charset": "UTF-8"}]
[{"name": "keywords", "content": "bar"}, {"charset": "UTF-8"}]
And this is a result of manipulating the state directly in your foo
function. You should never manipulate state directly, but always create new variables, so instead of
var newMeta = this.state.meta;
newMeta[0].content = bar;
try
var newMeta = [
{
...this.state.meta[0]
}
];
newMeta[0].content = bar;
With the spread operator we can make a new object with same values and then manipulate that new object to pass to Helmet.
from react-helmet.
Related Issues (20)
- react-helmet mixing fields during renderStatic HOT 1
- meta tag for facebook is not working. HOT 6
- Not properly working with new React18 root-api HOT 5
- Insert script tags in the <head> from CMS
- [RFF] Avoid Code Duplication
- Send Link
- is it safe? HOT 1
- Strange behavior with body className HOT 1
- How to add meta tags which I first need to fetch HOT 1
- Multiple `<Helmet>` tags will break (only one will render) HOT 3
- I recently used react helmet for changing title of all route links its perfectly working but the title is not change source code plz resolve this issue HOT 1
- Active support HOT 4
- How do I append a value to the title? HOT 3
- Warning 'UNSAFE_componentWillMount', How to fix the problem? HOT 4
- the meta tags is shown in page sourse but not shown in social media share,, any help? HOT 2
- local script and CSS file not working in React-Helmet HOT 1
- React Helmet Meta descriptions are not updated on Google Search HOT 1
- Do react-helmet support ESM tree shaking?
- Analysis: 68% of dependency updates in this repository can be merged.
- Bug: cannot remove/clear document title HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-helmet.