Accordion refactor: use ContentChildren instead of Query

[ng-bootstrap]

Accordion refactor: use ContentChildren instead of Query

[Foxandxss]

This works as a temporary workaround until Angular decides to do the ObserveChildren or whatever.

The panel is not generic, it depend on accordion and forces you to have a forwardRef.

Not sure why but I still have in mind that I tried something like this and there was a use case where it blows.

PS: You don't need .toArray() anymore.

[pkozlowski-opensource]

@Foxandxss thnx for looking into it.

This works as a temporary workaround until Angular decides to do the ObserveChildren or whatever.

Definitively, it is not the final impl.

The panel is not generic, it depend on accordion and forces you to have a forwardRef.

Totally. But at least a panel can use panels outside of an accordion (see the updated plunker).

Not sure why but I still have in mind that I tried something like this and there was a use case where it blows.

The use-case I was aware of is the one where there was an [open] binding on a panel, but this is covered.

PS: You don't need .toArray() anymore.

Right, thnx.

Can I interpret the above as a mild encouragement for a PR?

[Foxandxss]

Please go ahead, we are stuck on this for months. We need to move forward and more having ng2 around the corner.

If a better solution arrives, we do it.

[pkozlowski-opensource]

Done through b99ca44