Giter Site home page Giter Site logo

Comments (3)

NGnius avatar NGnius commented on August 16, 2024

I don't currently have any other devices to test on, so that's the primary limiting factor for me supporting other devices. Of course if someone else makes a PR, or I can get my hands on a device, then I'll be happy to merge/add support.

from fantastic.

NikhilSaini38 avatar NikhilSaini38 commented on August 16, 2024

I don't currently have any other devices to test on, so that's the primary limiting factor for me supporting other devices. Of course if someone else makes a PR, or I can get my hands on a device, then I'll be happy to merge/add support.

I have the device and can help develop, i have no prior rust experience so not sure what my code quality would be. What i've gathered we need to override fan control in sys.rs through /sys/class/hwmon/hwmon?/pwm1_enable which when set to 1 enables manual fan control and auto on 0.

Similarly /sys/class/hwmon/hwmon?/pwm1 controls fan speed it takes values 0-255 the.

On EC level oxp-mini-pro takes 0-100 values for fan speed control and aokzoe takes 0-255 but this is handled by the driver i mentioned,so fantastic only needs to target values 0-255.

The driver is hopefully going to be merged in kernel 6.2 and backported, a previous version for older oxp devices has already been merged in hwmon-next for kernel 6.1

We might need device specific overrides using DMI strings to select what config to apply.

One caveat is that device i currently have shows some default value of 2000 in /sys/class/thermal/thermal_zone0/temp i am trying to see what can be done to get it fixed.

I assume we wouldnt be able to fully implement fantastic without that. Maybe target amdgpu or aggregate temps while in development? Since they are in same package.

Also have you considered using fancontrold backend?

from fantastic.

Samsagax avatar Samsagax commented on August 16, 2024

I don't currently have any other devices to test on, so that's the primary limiting factor for me supporting other devices. Of course if someone else makes a PR, or I can get my hands on a device, then I'll be happy to merge/add support.

I can help with that... I'm working in a "general" fanc ontroller that would read/write to the sysfs hwmon exposes. I'm in the middle of it, but maybe we can join forces to leverage this project instead.

The main issue I think is making the interface generic to be able to control any pwm/fan the user chooses with any sensor (or combination of them, maybe) he chooses.

I'm not well versed in Rust so maybe I need to learn it to help. But count me in for the solution.

from fantastic.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.