Giter Site home page Giter Site logo

move lib to src for consistency about core HOT 3 OPEN

ngrx avatar ngrx commented on May 31, 2024
move lib to src for consistency

from core.

Comments (3)

MikeRyanDev avatar MikeRyanDev commented on May 31, 2024

Are you wanting it to be consistent across all ngrx projects? If that's the case, we'll need to update router, router-store, effects, notify, store-devtools, and store-log-monitor as well.

from core.

robwormald avatar robwormald commented on May 31, 2024

Yeah, I'd like to be consistent across projects and implement this proposal:

https://github.com/dherman/defense-of-dot-js/blob/master/proposal.md

TS source in /src
Output commonJS ES5 to the root
Output standard (ES) modules to /lib
Add module and modules.root to point to ESM entry point and modules

We'll implement the same in @angular and build our es module pipeline around it.

Thoughts?

from core.

MikeRyanDev avatar MikeRyanDev commented on May 31, 2024

Sounds good. To be clear, the ES modules we output to /lib need to be ES5 with ES6 modules, correct?

from core.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.