Comments (5)
Release notes generation is explained on this page with an example config yaml.
The primary goal is to make it easy-to-remember/hard-to-forget. Ideally it should be well-organized and not require manual edits, but that's nice-to-have.
Proposal:
- Add a
breaking-change
tag for any proto changes. - Add a
release-notes
tag for any other changes to include in the release notes.
We typically introduce breaking changes as part of a codegen change, sometimes the PR title will not be the best description of the break.
To mitigate this we should:
- Isolate the codegen change from addition of new APIs/features.
- Reword the title to emphasize the API change as much as reasonably possible (but don't force it).
- Add a "Breaking Change" section to the PR description describing the specific break.
- Reword the generated release notes as necessary.
Thoughts @reckenro @gregstoll @harsha-bhushan ?
from grpc-device.
1 sounds like kind of a pain in some cases. I think I'd lean towards 3 or 4. 4 sounds optimal if there aren't too many of these breaking changes. (which hopefully there won't be!)
from grpc-device.
Yeah, true. I'd say "Isolate the codegen change from addition of new APIs/features" is preferred in general and a stronger preference in this case. But, we override that preference pretty frequently for pragmatism's sake. That's fine. A softer guidance could be "think about if this change should be in release notes and, if so, what can you do to make this PR a better reference link?".
from grpc-device.
Yes, we shouldn't be breaking a lot of code.
Currently in the early adoption stage of the product & frequent releases, it's better to review & include only what is worth calling out in the release notes. And avoid cluttering the release notes & confusing especially the new users. We could add some other custom tag for such PRs, so that they are not automatically picked up while creating a release, but it would aid us update the notes.
But eventually, once we are done with all driver support & the community starts to contribute to this repo, we could have a more stricter guidance.
from grpc-device.
I went ahead and added a breaking-change tag and tagged the appropriate PRs. I'll figure out how to handle that when adding release notes.
from grpc-device.
Related Issues (20)
- Intermittent Test: FGEN test AllocateNamedWaveform_WriteNamedWaveformF64_WaveformWrittenSuccessfully HOT 1
- Code generation could be more efficient for simple 'repeated' types
- Review and merge request for new page in Wiki
- Update Linux RT Feed to point to new release 2.4.0
- Update Linux RT Feed to point to new release 2.5.0
- XNET test ConvertFramesToFromSignalsFromExample_CompareFrames_ValuesMatch fails on Ubuntu repeatedly
- Windows system test runner occasionally hits timeout HOT 1
- Addon metadata isn't merged by the build HOT 1
- Update Linux RT Feed to point to new release 2.2.0
- Remove SetRuntimeEnvironment override from nidcpower metadata upon metadata update
- Remove SetRuntimeEnvironment override from nidmm metadata upon metadata update
- Remove SetRuntimeEnvironment override from nidigital metadata upon metadata update
- Remove SetRuntimeEnvironment override from nifake metadata upon metadata update
- Remove SetRuntimeEnvironment override from nifgen metadata upon metadata update
- Remove SetRuntimeEnvironment override from niscope metadata upon metadata update
- Remove SetRuntimeEnvironment override from niswitch metadata upon metadata update
- Intermittent Test: NiRFmxInstrDriverApiTests.GetNIRFSASession_SelfTest_Succeeds
- Intermittent Test: NiRFmxWCDMADriverApiTests.ModAccMarkerModeFromExample_FetchData_DataLooksReasonable
- Intermittent Test: NiFgenDriverApiTest.SetAttributeViBoolean_GetAttributeViBoolean_ValueMatches HOT 1
- Update Linux RT Feed to point to new release 2.3.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grpc-device.