Documentation says OR, code says AND?

[nicklockwood]

Documentation says OR, code says AND?

[nicklockwood]

The logic above is to check if the shouldPromptForRating function should return NO, in other words:

"if too few uses AND too few events then DO NOT prompt"

This is consistent with the documentation, because the implication here is that if either the uses or the events thresholds are met then then above condition will fail and it will prompt.

[robotron2084]

That logic is failing for me because the use count is being met but the events count isn't and it is NOT returning no . The implication it seems to me is that both conditions must be met, and if one is met, but the other isn't, then it will not return NO (sorry about that double negative. My situation:

irate.usesUntilPrompt = 3;
irate.eventsUntilPrompt = 16;

I'll get 3 uses, and 3 events:

if (3 < 3 /* false _/ && 3 < 16 /_true*))
{
// False and true do not equal true, so this will not occur, but I want it to. I do not want to show the prompt just yet.
}

I'm rushing out the door to get my wisdom teeth removed, so I hope I got this right. I won't be able to reply until the meds wear off. :D

Thanks for your fast reply!

[nicklockwood]

Yes, so (using your example) the documentation says that the prompt will show if 3 < 3 or 3 < 16, and that's what's happening. What you are now saying is that you only want it to show if 3 < 3 and 3 < 16, contrary to the documentation.

Arguably I guess that may be more useful, so I might consider changing this behaviour, but it's technically correct as documented.

To override the prompt logic, without modifying the library (which is a bad idea for future compatibility), you can implement the iRateDelegate and supply your own logic in the iRate:shouldPromptForRating: delegate method.

[nicklockwood]

I looked into changing the way it works, but it would be too likely to introduce bugs in existing projects due to the defaults. Since both useCount and eventCount default to 10, and both are optional, if I made them mandatory, users would have to remember to set eventCount to zero if they weren't using it, otherwise the rating would never appear. I think it's best just to leave it as it is.

[robotron2084]

Hi Nick,

Thanks for looking into this but you're correct to leave it as it is, and the documentation is correct. I was confused by the double negative, sorry about that! I do think that i will hack my copy tho to be OR instead of AND because for my purposes it makes more sense.

Thanks again,
C