Improve Maven module detection

[nidi3]

Improve Maven module detection

[nidi3]

Hm, what's your setup?
I can run e.g. the project's own tests in maven and in intellij and they both work.

[axelfontaine]

Versions

• Maven 3.5.0
• IntelliJ 2017.2.3
• code-assert 0.0.13

Working directory when running tests

• Maven always uses the current module root as the working directory.
• IntelliJ uses the project root as the working directing.

AnalyzerConfig.maven().main()

• Maven full build: works
• Maven module build: works
• IntelliJ: breaks with Invalid directory or JAR file: target/classes

AnalyzerConfig.maven(module).main()

• Maven full build: breaks with Invalid directory or JAR file: mymodule/target/classes
• Maven module build: breaks with Invalid directory or JAR file: mymodule/target/classes
• IntelliJ: works

One more thing in case this helps: my base test case is in a separate testmodule which is added in test scope to every other module which then contains its own subclass with the rules for that module.

[nidi3]

Are you using windows?
There is already a check, but probably not os-safe.

[axelfontaine]

Yes, Win 10 x64

[nidi3]

Should be fixed in 0.8.1

[axelfontaine]

This appears to still be broken in IntelliJ with 0.8.2. I still need to use my workaround with that version.

[nidi3]

I still cannot reproduce the error.
The check is here:

code-assert/code-assert/src/main/java/guru/nidi/codeassert/config/AnalyzerConfig.java

Line 149 in f1fd5ea

return new File("").getAbsoluteFile().getName().equals(module);

Could you try and see what's going on? Thanks!

[axelfontaine]

Upon further testing, AnalyzerConfig.maven(module).main() now works both in Maven and IntelliJ.

AnalyzerConfig.maven().main() remains broken in IntelliJ, but in a different way: nothing is found! In this case the runningInModuleDir() method you mentioned also is not called.

[nidi3]

In this case, I guess, the working dir is the project root. Without a given module, how can it know the correct dir?
Btw I still cannot reproduce this. How exactly do you run the test with IntelliJ so that the working dir is not the module dir?