Comments (5)
Maybe we should not force to set isNumber, but limit the validator to input[type=number]
or rename the validator
from ngx-validators.
I don't think so since the min and max validator for type=number
already is shipped by angular. This validator only works on text inputs that are going to be used as number inputs. For example, when the user needs to enter 001
or values that are not allowed by normal number input.
from ngx-validators.
Renaming it is also a good approach to me
from ngx-validators.
have you taken a decision yet?
from ngx-validators.
I will rename it, but i thinking about removing it completely.
But both options are breaking changes
from ngx-validators.
Related Issues (20)
- address validator
- Angular-seed package HOT 3
- no whitespace or empty string HOT 4
- update to angular 4
- Add more valid region codes HOT 2
- Improve errors by including instantiation parameters HOT 2
- Option to allow mismatchedPasswords to only trigger if fields have values HOT 4
- google-libphonenumber dependency adds 366Kb to my vendor file! HOT 8
- Mailcheck HOT 2
- Mismacth passwords HOT 1
- Reactive forms errors code in html
- Project Question HOT 2
- fix removeError in Util HOT 3
- Migrate to Angular 7 HOT 1
- min and max validation are not working when validator @input value change HOT 2
- Build broke after update from 5.0.0 to 5.1.0 HOT 2
- Calling before registerOnValidatorChange is called causes an error HOT 4
- How to validate on submit?
- [Enhancement] Min/Max date validator
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngx-validators.