Giter Site home page Giter Site logo

Comments (5)

Nightapes avatar Nightapes commented on May 27, 2024

Maybe we should not force to set isNumber, but limit the validator to input[type=number] or rename the validator

from ngx-validators.

luisvt avatar luisvt commented on May 27, 2024

I don't think so since the min and max validator for type=number already is shipped by angular. This validator only works on text inputs that are going to be used as number inputs. For example, when the user needs to enter 001 or values that are not allowed by normal number input.

from ngx-validators.

luisvt avatar luisvt commented on May 27, 2024

Renaming it is also a good approach to me

from ngx-validators.

luisvt avatar luisvt commented on May 27, 2024

have you taken a decision yet?

from ngx-validators.

Nightapes avatar Nightapes commented on May 27, 2024

I will rename it, but i thinking about removing it completely.
But both options are breaking changes

from ngx-validators.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.