@ValidateNested doesn't work without custom validate function

[nikaple]

@ValidateNested doesn't work without custom validate function

[Nikaple]

I tried downgrade and lock the version of class-transformer to 0.4.0, and it works fine. Maybe it's an issue with class-transformer. Needs further investigation.

Edit: You're not able to start example app because you didn't install the dependencies in the root folder. The example apps shares the same dependencies as the main lib, as well as the class-transformer, which is locked at version 0.4.0

Edit again: I think I got it. When your installed version of class-transformer is not the same with nest-typed-config's version, the metadata defined in ConfigModule goes into node_modules/class-transformer, but when calling plainToClass in the library code, it uses node_modules/nest-typed-config/node_modules/class-transformer, which didn't own the metadata you provided.

So for the solution:

1. (temporary) Downgrade class-transformer to 0.4.0 to match library's, or copy the validate function.
2. Introduce a breaking change into the library, which declares class-transformer as peerDependencies.

I would try to implement the second solution asap(including code, docs, migration guide, etc.), but I'm busy for the next one or two weeks, feel free to propose a PR if you want the feature to be released quicker!

[imkh]

I tried downgrade and lock the version of class-transformer to 0.4.0, and it works fine. Maybe it's an issue with class-transformer. Needs further investigation.

Good catch, I didn't think of downgrading class-transformer, I only noticed after the fact that the examples shared the same 0.0.4 version as the main lib. Let me know if you need anything else.

[Nikaple]

I've edited my previous comment, please check it out 😸

[imkh]

Nice, thanks for looking into it. I'm not sure exactly what change is needed in the lib to fix the bug though and I'm not in any rush, so I don't mind waiting and using the custom validate function in the meantime.

[andrey-hohlov]

@Nikaple is there any chance for

Introduce a breaking change into the library, which declares class-transformer as peerDependencies.

?

We are trying nest-typed-config as a replacement for @nestjs/config. It works well except class-transformer versions mismatch. We don't wan / cannot downgrade its version.

temp solution that we can use, but...

"postinstall": "rimraf node_modules/nest-typed-config/node_modules/class-transformer"

[Nikaple]

PR #186 tries to fix this issue by import deps from root node_modules first, see:

https://github.com/Nikaple/nest-typed-config/blob/fix%2Fissue-149/lib/utils/imports.util.ts#L5

@andrey-hohlov Please let me know if you have any suggestions

[github-actions]

🎉 This issue has been resolved in version 2.4.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[andrey-hohlov]

@Nikaple I tried new version and it works. But I'm not sure about the solution.

@nestjs/common accepts any version of class-transformer and class-validator and lists them in peerDependencies.

In my opinion, the right strategy is to follow versions that are used in actual nestjs package - version * in peerDependencies.

[Nikaple]

Yes, it's kinda hack, but I want to keep this lib as stable as possible, avoid breaking changes when it doesn't have to.

[svyatogor]

This solution completely breaks building monorepos unfortunately. Dynamic requires are not processed by webpack and result in Uncaught Error: Cannot find module 'class-validator'

[Nikaple]

@svyatogor Can you provide a minimum reproduction repo? If it's a newly introduced bug, you can file a separate issue.