Comments (6)
We currently don't have end linenos for these -- that would require migrating to decl node types for these upstream.
I think it might also be worth considering going the other way around and drop the special Decl
nodes. Apart from the end lineno, the name and docComment can just be normal children. The fact that we have Decl
nodes right now is an artifact of the internal implementation, and I'm not sure how much sense it really makes.
from php-ast.
Before proceeding on #55 I'd like to have some feedback on the previous comment. What do you think about dropping Decl nodes and just using one structure for everything? The node/decl distinction is an artifact of the implementation, I don't think keeping the distinction makes much sense.
from php-ast.
What do you think about dropping Decl nodes and just using one structure for everything?
I think it makes sense. One would want want to keep Decl around for a few releases though, and only unify Nodes in version 45.
from php-ast.
I think it makes sense. One would want want to keep Decl around for a few releases though, and only unify Nodes in version 45.
Of course, it will stay around until all current versions of the AST are phased out.
Are there other changes that should go into the next AST version?
from php-ast.
#58 is something I'd want in the next AST version, but not strictly necessary.
Other than that, I can't really think of any enhancements/consistency changes I want.
from php-ast.
Normalization away from Decl implemented in cca3151.
from php-ast.
Related Issues (20)
- Support php 8.0 attributes
- Idea: Adding new parameter flag PARAM_MODIFIER_PUBLIC for AST_PARAM HOT 1
- Changing values of constants HOT 4
- Support ZEND_AST_ATTRIBUTE_GROUP for #[Attr1, Attr2] HOT 1
- Make version 80 the current version
- Dropping support for php 7.1 and older? HOT 2
- Test failing with 8.0.0beta4 HOT 2
- Add ast_dump option: AST_DUMP_EXCLUDE_DOC HOT 2
- Utilize in C# (e.g. exposing php-ast as a standalone library that can be used from other programming languages) HOT 1
- Travis -> GH Actions HOT 4
- make command error HOT 2
- Idea: Make ast\Node->endLineno a declared property? HOT 5
- Windows: Pecl DLL for PHP 8.1 HOT 8
- Question about class `implements` and `extends` HOT 1
- Why some built-in functions have special AST type ? HOT 1
- Expose php 8.2 `ENCAPS_VAR_DOLLAR_CURLY*` flags in ast\flags
- php 8.2 changed the ast representation of short arrow functions HOT 1
- [question] How to list all classes that used in a file? HOT 2
- php-ast 1.1.0 DLL for Windows HOT 8
- Fails to Compile with PHP 8 includes (changed prototype for "zend_prepare_string_for_scanning()") HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from php-ast.