Convert AST_CONST_ELEM and AST_PROP_ELEM to \ast\Node\Decl in version 45?

[nikic]

Convert AST_CONST_ELEM and AST_PROP_ELEM to \ast\Node\Decl in version 45?

[nikic]

We currently don't have end linenos for these -- that would require migrating to decl node types for these upstream.

I think it might also be worth considering going the other way around and drop the special Decl nodes. Apart from the end lineno, the name and docComment can just be normal children. The fact that we have Decl nodes right now is an artifact of the internal implementation, and I'm not sure how much sense it really makes.

[nikic]

Before proceeding on #55 I'd like to have some feedback on the previous comment. What do you think about dropping Decl nodes and just using one structure for everything? The node/decl distinction is an artifact of the implementation, I don't think keeping the distinction makes much sense.

[TysonAndre]

What do you think about dropping Decl nodes and just using one structure for everything?

I think it makes sense. One would want want to keep Decl around for a few releases though, and only unify Nodes in version 45.

[nikic]

I think it makes sense. One would want want to keep Decl around for a few releases though, and only unify Nodes in version 45.

Of course, it will stay around until all current versions of the AST are phased out.

Are there other changes that should go into the next AST version?

[TysonAndre]

#58 is something I'd want in the next AST version, but not strictly necessary.

Other than that, I can't really think of any enhancements/consistency changes I want.

[nikic]

Normalization away from Decl implemented in cca3151.