Giter Site home page Giter Site logo

Comments (6)

nikic avatar nikic commented on May 18, 2024 1

To clarify, this is about the case where the class is indented? So

<?php
    class Example {
    }

becomes

<?php
    /** foo */
class Example {
    }

instead of

<?php
    /** foo */
    class Example {
    }

?

from php-parser.

danon avatar danon commented on May 18, 2024

I noticed, that if I use <? then it works fine :o If I use <?= then it works fine too!

Only <?php is buggy.

from php-parser.

nikic avatar nikic commented on May 18, 2024

I think this is due to the annoying special case where the newline after <?php is actually considered part of the opening token, so this doesn't get detected as indentation...

from php-parser.

danon avatar danon commented on May 18, 2024

To clarify, this is about the case where the class is indented? So

[...]

becomes

[...]

instead of

[...]
?

Exactly!

Wow, this fix was so quick! Great work.

Can this be released soon-ish? I would like to start using it asap.

from php-parser.

nikic avatar nikic commented on May 18, 2024

@danon Done! https://github.com/nikic/PHP-Parser/releases/tag/v5.0.2

from php-parser.

danon avatar danon commented on May 18, 2024

@nikic Thanks!

from php-parser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.