Run-time error for searches with just an exclusion term (with a solution)

[nim-lang]

Run-time error for searches with just an exclusion term (with a solution)

[Leu-Gim]

There still remain many ways to raise an error with that code, so it's better instead of that to add exception handling for SQLite calls: to replace (lines 1348-1350)

      for rowFT in fastRows(db, queryFT,
                    [q,q,$ThreadsPerPage,$c.pageNum,$ThreadsPerPage,q,
                     q,q,$ThreadsPerPage,$c.pageNum,$ThreadsPerPage,q]):

with

      let rows =
            try: getAllRows(db, queryFT,
                    [q,q,$ThreadsPerPage,$c.pageNum,$ThreadsPerPage,q,
                     q,q,$ThreadsPerPage,$c.pageNum,$ThreadsPerPage,q])
            except: @[]
      for rowFT in rows:

[markprocess]

@Leu-Gim can you reproduce this in the current deployment? I was unable to. Regards, Mark. cc @dom96

[Leu-Gim]

After transition to Karax (the new forum) - don't work any more at all, as I see,
and "-someword" is treated as just "someword".

If it worked, the issue would not be visible to users, I think,
because results are fetched via ajax,
via subrequests to /search.json?q=...,
and that exception would raise in that request,
and at client side there's a check for HTTP status of the ajax request prior to processing results.

[Leu-Gim]

Say "-nick" returns results for "nick"...

[Leu-Gim]

Oh, Forum has been moved to SQLite's "Enhanced Query Syntax" (https://sqlite.org/fts3.html) now, as I see - AND, OR and parrentheses work. Then NOT should work instead of -.

[Leu-Gim]

Yes, NOT does work too. An example query with all three operators and () for test: "(csp AND oberon) OR (actionscript NOT mtasc)" (picked for obviousness).

Queries with just negation (NOT word) still fail, and the server doesn't work then for a couple of seconds. So the issue is the same, with just NOT instead of -. And solution is the same.

[markprocess]

@Leu-Gim Thanks - I will study your comments soon. Mark.