Giter Site home page Giter Site logo

Comments (5)

NimaSoroush avatar NimaSoroush commented on May 13, 2024

Hi Richard,

Thanks for raising this. Yeah, it makes total sense. Do you mind adding a PR for this? Should be a quick one.
@badsyntax

from differencify.

ms88privat avatar ms88privat commented on May 13, 2024

I like the idea of using puppeteer, image comparison and jest snapshots together. What I don't like is this custom API of differencify. We will never be up2date with puppeteer and the user has to learn again a new API. Can we not just use puppeteer and call a snapshot function wherever we want to compare some screenshots? I know it is simpler said then done. But can we try? I would love to help, this project as a lot of potential. It could be similar to https://www.cypress.io/

from differencify.

NimaSoroush avatar NimaSoroush commented on May 13, 2024

You are right @ms88privat and I thought a lot about this to make the API similar to puppeteer API. Although there are some issues that I am concerned about:

  • Chaining over different method calls.
  • Failing early in case any of steps went wrong
  • Custom debugging that differencify provides
  • Browser instance management that differencify does behind the scene

All of them achievable by keeping the differencify interface matching puppeteer on the fly. Just need some extra work.
I am happy to explore all I mentioned above in a separate branch and address them one by one together @ms88privat

from differencify.

NimaSoroush avatar NimaSoroush commented on May 13, 2024

I raised this issue to follow up on matching differencify and puppeteer API.

@badsyntax: This should potentially solve your issue as well

from differencify.

NimaSoroush avatar NimaSoroush commented on May 13, 2024

Closed by [#54]

from differencify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.