{error, no_cert} with `certs_keys` from OTP 25

[leoliu]

{error, no_cert} with `certs_keys` from OTP 25

[Maria-12648430]

@essen see #343 😉

[essen]

Hmm I don't think we do explicit checks, we just pass to ssl. Can you provide an example of Ranch use where you get this error?

[leoliu]

@essen I think ranch_ssl:listen/1 may be the culprit. I pass a dummy {sni_hosts, []} to get it working.

[Maria-12648430]

Hmm I don't think we do explicit checks, we just pass to ssl. Can you provide an example of Ranch use where you get this error?

We do, here: https://github.com/ninenines/ranch/blob/master/src/ranch_ssl.erl#L115-L128

[essen]

Yep you're both right. I can look on Monday but a PR is welcome in the meantime.

[essen]

@leoliu Hello! Can you try the linked PR and confirm it fixes your issue? Thanks!

[leoliu]

@essen Yes {error, no_cert} is gone.

[essen]

Fixed, thanks!