Giter Site home page Giter Site logo

Comments (5)

satra avatar satra commented on September 28, 2024

noted - we did a big merge with a large number of changes. time to clean up the changes from this.

from heudiconv.

yarikoptic avatar yarikoptic commented on September 28, 2024

This I think bitten me as well a few times. But I just found peace of mind with it as a feature ;-)

from heudiconv.

satra avatar satra commented on September 28, 2024

@poldrack - as we move forward with this codebase, we will be bringing in a few more things.

  • change in heuristic | heudiconv | environment will trigger a regeneration. at present there are two primary sources of difference: heuristic, dcm2niix but changes could come from heudiconv itself as well.
  • integration of dcmstack into nibabel and/or extraction of features via other means

i think the biggest drawback from a testing standpoint is the absence of sufficient varied dicom datasets.

from heudiconv.

yarikoptic avatar yarikoptic commented on September 28, 2024

I think that the problem is also due to trying to address two target use-cases:

  • original two stage:
    1. generate .edit.txt with mapping to be adjusted if needed
    2. run actual conversion
  • single stage:
    1. convert what is given without giving even a chance to adjust anything

The "single stage" is kinda my use-case which I added later, while "original two stage" is what Satra+Michael envisioned/implemented originally. And ATM it is not clear when heudiconv performs in two stage or a single stage scenario.
In my case, I am trying to avoid silent 're-conversion' since it could lead to spurious files laying around left from previous attempts with previous heuristic and inconsistent conversion altogether. That is why added explicit --overwrite flag to instruct when I explicitly want to overwrite previous results of the conversion, and otherwise to crash if any files tries to override any previous present file (be it a converted or a heuristic file).

I think we should sit down (during code rodeo) and outline major use-cases/workflows we would like to see supported, and make them clear(er) presented in API/documentation.

from heudiconv.

satra avatar satra commented on September 28, 2024

@yarikoptic - sounds like a good discussion topic for code rodeo.

from heudiconv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.