Comments (5)
noted - we did a big merge with a large number of changes. time to clean up the changes from this.
from heudiconv.
This I think bitten me as well a few times. But I just found peace of mind with it as a feature ;-)
from heudiconv.
@poldrack - as we move forward with this codebase, we will be bringing in a few more things.
- change in
heuristic | heudiconv | environment
will trigger a regeneration. at present there are two primary sources of difference: heuristic, dcm2niix but changes could come from heudiconv itself as well. - integration of dcmstack into nibabel and/or extraction of features via other means
i think the biggest drawback from a testing standpoint is the absence of sufficient varied dicom datasets.
from heudiconv.
I think that the problem is also due to trying to address two target use-cases:
- original two stage:
- generate .edit.txt with mapping to be adjusted if needed
- run actual conversion
- single stage:
- convert what is given without giving even a chance to adjust anything
The "single stage" is kinda my use-case which I added later, while "original two stage" is what Satra+Michael envisioned/implemented originally. And ATM it is not clear when heudiconv performs in two stage or a single stage scenario.
In my case, I am trying to avoid silent 're-conversion' since it could lead to spurious files laying around left from previous attempts with previous heuristic and inconsistent conversion altogether. That is why added explicit --overwrite
flag to instruct when I explicitly want to overwrite previous results of the conversion, and otherwise to crash if any files tries to override any previous present file (be it a converted or a heuristic file).
I think we should sit down (during code rodeo) and outline major use-cases/workflows we would like to see supported, and make them clear(er) presented in API/documentation.
from heudiconv.
@yarikoptic - sounds like a good discussion topic for code rodeo.
from heudiconv.
Related Issues (20)
- Add/Extend dataset_description.json:GeneratedBy with information about heudiconv/heuristic (if possible)/dcm2niix
- Add auto-changelog conventions to Contributors guide HOT 1
- [JOSS]: narrate James Kent's tutorial into a "script" tutorial within our documentation HOT 1
- Audit custom heuristics tutorial
- reproin: might want to change logic for dups to actually use datetime not seq number HOT 1
- why release check said it is not needed? HOT 2
- Dicom to Nifti Singularity Conversion Error: numpy.exceptions.AxisError: axis 1 is out of bounds for array of dimension 1 HOT 1
- Skip images that have already been converted instead of throwing an error HOT 1
- having an option to rerun heuristic instead of reload HOT 4
- BOLD_NOT_4D for one particular run (converting both single band and multi band files)
- enhanced dicoms (XA) and sequence_name in PulseSequenceName dicom tag
- ORCID for JOSS publication for @toddt HOT 1
- ReproIn name for siemens GRE fieldmap? one name in cockpit makes dicoms with two SeriesIds (mag and phase) HOT 2
- populate_intended_for prefers `task` entity with `CustomAcquisitionLabel` method HOT 4
- ReproIn heuristic uses `phase` suffix instead of `part-phase`
- Dicom to BIDS--Manual renaming Help!
- Converting large numbers of DICOM image produces no results
- events files get re-created for existing bold files (batch/incremental mode)
- How are task-....json files created?
- Feature Request: support dicom datetime with timezone information
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from heudiconv.