Giter Site home page Giter Site logo

Comments (17)

niuhuan avatar niuhuan commented on June 19, 2024 1

贡献者里没有你,应该是rebase merge的问题。我手动又强推了一下,有了。

from rust_proc_qq.

niuhuan avatar niuhuan commented on June 19, 2024

这是个很好的提议。建议和module类似可以直接设置并使用。我很乐意接收这个想法。

需要注意以下。我刚提了一个PR,改动比较大。#36

from rust_proc_qq.

niuhuan avatar niuhuan commented on June 19, 2024

如果可以的话merge以下master之后进行PR。

from rust_proc_qq.

rcoplo avatar rcoplo commented on June 19, 2024

如果可以的话merge以下master之后进行PR。

好的

from rust_proc_qq.

niuhuan avatar niuhuan commented on June 19, 2024

我先尝试改一下你的代码,比如

  • jobs_scheduler 放在client里面,不需要建立多个。
  • 让handler返回result,这样用起来方便一起
  • 或者在clientBuilder::build的时候就执行一些init的动作,而不是推迟到run。

遇到问题我会推送到dev给你看一下

from rust_proc_qq.

rcoplo avatar rcoplo commented on June 19, 2024

我先尝试改一下你的代码,比如

  • jobs_scheduler 放在client里面,不需要建立多个。
  • 让handler返回result,这样用起来方便一起
  • 或者在clientBuilder::build的时候就执行一些init的动作,而不是推迟到run。

遇到问题我会推送到dev给你看一下

from rust_proc_qq.

niuhuan avatar niuhuan commented on June 19, 2024

4d21100

我把我刚才的想法加了进去,我只改了 proc_qq 没有改 codegen.

jobs_scheduler.start() 这个名字我看你用tokio::spawn调用,start看起来是启动的意思。我用了一个mutex包裹jobs_scheduler不知道会不会有问题

from rust_proc_qq.

niuhuan avatar niuhuan commented on June 19, 2024

我的想法是一开始就设置好任务,然后一起启停,

use std::future::Future;

from rust_proc_qq.

niuhuan avatar niuhuan commented on June 19, 2024

如果按照这个思路改 scheduler 跟module的思路就比较一致了。 codegen也类似

from rust_proc_qq.

niuhuan avatar niuhuan commented on June 19, 2024

你可以试一下有没有问题或者补充其他的,能用的话我可以提交到master了

from rust_proc_qq.

rcoplo avatar rcoplo commented on June 19, 2024

我试了一下,当shutdown() 之后,再次start()就会报错了,JobScheduler 需要重新初始化,添加任务才行

from rust_proc_qq.

niuhuan avatar niuhuan commented on June 19, 2024

我试了一下,当shutdown() 之后,再次start()就会报错了,JobScheduler 需要重新初始化,添加任务才行

我改一下

from rust_proc_qq.

niuhuan avatar niuhuan commented on June 19, 2024

改好了

from rust_proc_qq.

rcoplo avatar rcoplo commented on June 19, 2024

没问题了,可以加个ModuleScheduler添加的时候的日志吗

from rust_proc_qq.

niuhuan avatar niuhuan commented on June 19, 2024

调用的时候?我写todo的时候吗?文档还需要改一改

from rust_proc_qq.

rcoplo avatar rcoplo commented on June 19, 2024

调用的时候?我写todo的时候吗?文档还需要改一改

这种
加了日志好观察模块是否加载.

from rust_proc_qq.

niuhuan avatar niuhuan commented on June 19, 2024

调用的时候?我写todo的时候吗?文档还需要改一改

这种 加了日志好观察模块是否加载.

我把我的定时任务的代码提交到master了。增加了在编译时校验cron是否正确。

builder::build里面加上tracing::debug? 如果是的话,你可以pr一下。

from rust_proc_qq.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.