Indent and syntax highlighting broken for ${..}

[nixos]

Indent and syntax highlighting broken for ${..}

[matthewbauer]

Sorry, I wasn't clear:

I had the same problem that you are describing and it was fixed by running this:

(makunbound 'nix-mode-syntax-table)

And reloading the new nix-mode. The problem seems to be from having already loaded the earlier nix-mode that has the bad syntax table.

[teh]

AFAICT there is no simple fix. What we'd need is antiquotation to have both the ( and the | property.

(defun nix-syntax-propertize-close-brace ()
  "Set syntax properties for close braces.
If a close brace `}' ends an antiquote, the next character begins a string."
  (let* ((start (match-beginning 0))
         (context (save-excursion (save-match-data (syntax-ppss start))))
         (open (nth 1 context)))

    (when open ;; a corresponding open-brace was found
      (when (get-text-property open 'nix-syntax-antiquote)
        (put-text-property start (+ 1 start)
                           'syntax-table (string-to-syntax "|"))
	(put-text-property start (+ 1 start)
			   'syntax-table (string-to-syntax ")"))
	(put-text-property start (+ 1 start)
			   'nix-syntax-antiquote t)))))

[matthewbauer]

Ok, I think that @ljli has fixed this. Can you verify that those changes are good?

[teh]

Seems to mostly work, thanks!

[matthewbauer]

Awesome!

[Ericson2314]

Not so fast :). "${null}" asdf messes up (string literal doesn't end). Adding a character between } and " fixes.

[matthewbauer]

See https://github.com/matthewbauer/nix-mode/pull/13#issuecomment-289954158

[Ericson2314]

Err, I am testing on latest master.

[Ericson2314]

Worked! Thanks, and sorry for missing that.