Giter Site home page Giter Site logo

Comments (3)

nk-o avatar nk-o commented on August 25, 2024

Hi, Alex.

Thank you for kind words.

  • As you can see, I added comment for this code block
    // check if one of parents have transform style (without this check, scroll transform will be inverted)

    So, parallax will be inverted. This occurs because of parallax block have position fixed and this position breaks when one of the parents have transformations. You can test it by yourself by adding transform style on one of the parent after Jarallax init. Stack Overflow

    For example this fix needs when you use parallax effect inside carousels (on one of my premium themes there is parallaxed carousel).

  • Left margin for horizontal centering image inside block. Do you have troubles with it? Where I can check it? On demo page it working fine.
    Example:

------------------------------
|           Image            |
|      |--------------|      |
| <--> |    Block     | <--> |
|      |--------------|      |
|                            |
------------------------------
  • Thank you for fixes. I'll check it and update Jarallax soon.

Best regards, nK.

from jarallax.

afanjul avatar afanjul commented on August 25, 2024

Many thanks Nikita, we are adapting and fixing your code to our needs, when we finish adapting, I will send you the code so you could see if there is something interesting for you... ok?

Could we ask another question?: why do you remove user original background-image styles? It is for performance? any browser bug? just for security?

// remove default user background
    _this.css(_this.$item, {
      'background-image'      : 'none',
      'background-attachment' : 'scroll',
    'background-size'       : 'auto'
});

For our "Html Editor" needs, we need to keep the original background-image just there (ie. not remove original styles and recover later). Is there any problem with that? could we get into problems for some case?

thanks in advance

from jarallax.

nk-o avatar nk-o commented on August 25, 2024

Ok, will be appreciated for any code.

Background image removed for performance reasons. There is no need to show background image + parallax image because of parallax image shows over background image.
I think modern browsers don't have problems with performance, but I leave this code just for case if not.

If you want to return image back - just destroy jarallax.

from jarallax.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.