Giter Site home page Giter Site logo

Comments (5)

AmineI avatar AmineI commented on May 29, 2024

Hi there ! Indeed, looks like I fixed the people posters filtering but broke the search ones.

Another small fix that could work would be to add a specific class for the people posters and apply "position : unset" to that specific class - thus keeping the search pages layout intact.

What do you think ?

from trakttvstats.

nliautaud avatar nliautaud commented on May 29, 2024

Hi !

Won't the filtering behavior still broke the page anyway due to the tabbed layout, even with the css fix ?
I think I explored quickly that solution a week ago, and that's why I came to the conclusion that the only quick fix that would reach a releasable state would be to disable the filtering completely. And that then bringing back the filtering would require at minimum reworking the js logic.

from trakttvstats.

AmineI avatar AmineI commented on May 29, 2024

I'm not sure I understand - apologies, as I'm not too familiar with the stats features.

I though the problem was that :

Without position : unset With position : unset
image image

So I thought we could apply the position : unset only on the posters from the people page, but it looks like I'm forgetting something ?

from trakttvstats.

nliautaud avatar nliautaud commented on May 29, 2024

At first sight yes, but the fact that the content is somewhat still here without changing the controller logic is totally due to chance :), but the page is still fundamentally broken.
You have probably the new tabbed block div.tab-content.credits, emptied by the extention (that move the posters elsewhere, according to the previous layout) present in the bottom of the page.

20210203140345_chrome

from trakttvstats.

EremesNG avatar EremesNG commented on May 29, 2024

I tried with this:

@-moz-document url-prefix("https://trakt.tv/people/") { .col-xs-1, .col-sm-1, .col-md-1, .col-lg-1, .col-xs-2, .col-sm-2, .col-md-2, .col-lg-2, .col-xs-3, .col-sm-3, .col-md-3, .col-lg-3, .col-xs-4, .col-sm-4, .col-md-4, .col-lg-4, .col-xs-5, .col-sm-5, .col-md-5, .col-lg-5, .col-xs-6, .col-sm-6, .col-md-6, .col-lg-6, .col-xs-7, .col-sm-7, .col-md-7, .col-lg-7, .col-xs-8, .col-sm-8, .col-md-8, .col-lg-8, .col-xs-9, .col-sm-9, .col-md-9, .col-lg-9, .col-xs-10, .col-sm-10, .col-md-10, .col-lg-10, .col-xs-11, .col-sm-11, .col-md-11, .col-lg-11, .col-xs-12, .col-sm-12, .col-md-12, .col-lg-12 { position : unset !important; } }

Works to me:

User People
msedge_ksmac7iMWV msedge_nNecOecolh

from trakttvstats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.