Consider Embedding the SE.Redis Library

[nlog]

Consider Embedding the SE.Redis Library

[304NotModified]

Do you mean there is no external and one dll? Or only the first one?

[Silvenga]

Yeah, one DLL.

[304NotModified]

I think the .Net world is now getting used to (many) nuget packages, so I don't think this will be an improvement

[Silvenga]

I was think it was more about allowing for multiple versions of a package at the same time during runtime. I'm unsure how compatible multiple versions of StackExchange.Redis are.

[joshua5822]

This is a problem now, since we can't update to the 2.X versions of StackExchange.Redis. The two options are to either update NLog.Target.Redis to the latest StackExchange.Redis package or to embed like @Silvenga mentioned.

[304NotModified]

update NLog.Target.Redis to the latest StackExchange.Redis

That sounds good to me. Could you send a pr?

I think embedding other libraries is anti oss and anti modular pattern and there are no plans to do so.

[Silvenga]

@304NotModified I wouldn't go as far as say anti-OSS - it's basically static linking in other projects. It's done all the time in OSS since it reduces coupling between libraries.