Comments (3)
I wanted to do something productive this morning and thought I would give this a whack. ToolStripMenuItemTarget and MessageBoxTarget's already support them, FormControlTarget was trivial to update, but layoutable properties has some larger implications for the RichTextBoxTarget.
RichTextBoxTarget was designed with the presumption that each target would specify a single RichTextBox. If the control and form name are Layout's instead of fixed strings, there is the possibility that the layout could render differently each time the same target is used and the 1 to 1 contract of target to RichTextBox is broken.
The target can still be reworked to find/create the appropriate RichTextBox on each log call, but this is a significant change to functionality.
The object references to the target's form and RichTextBox would have to be removed, as well as the static functions to find RichTextBoxTarget from a RichTextBox. The tests rely on these and would have to be reworked and could impact any users who might be using these.
I'm inclined to say it's worth it to add the flexibility of layoutable properties, but given y'alls rigorous testing strategy, maintaining compatibility could be a higher priority.
from nlog.windows.forms.
The target can still be reworked to find/create the appropriate RichTextBox on each log call, but this is a significant change to functionality.
We could still use layouts, but only support them when doing a new initialize or something like that.
from nlog.windows.forms.
I wanted to do something productive this morning and thought I would give this a whack. ToolStripMenuItemTarget and MessageBoxTarget's already support them, FormControlTarget was trivial to update, but layoutable properties has some larger implications for the RichTextBoxTarget.
Thanks for that!
from nlog.windows.forms.
Related Issues (20)
- net6.0-windows
- Fix default layout comments
- Breaking changes version 5
- Change AssemblyVersion to 5.0.0.0
- Using Only NLog.config for RichTextBox Does Not Log HOT 3
- Add net6.0-windows since LTS
- Continuous Build not running on merge to master HOT 1
- NullReferenceException in RichTextBoxTarget SendTheMessageToRichTextBox
- NLog.LogManager.Configuration reload causes RichTextBoxTarget to create a new form HOT 6
- Question: Is it possible to write to winforms ListView? HOT 2
- Form hanging when RichTextBox target nonstop logging HOT 6
- Symbols package publishing failed. HOT 1
- System.NullReferenceException calling ReInitializeAllTextboxes() HOT 5
- Missing source package on NuGet HOT 4
- RichTextBoxTarget - An exception occurred under NET48 HOT 3
- Create a nuget package with net5.0-windows platform supporting HOT 3
- No RowColor for RichTextBoxTarget when LeftToRight.Yes set HOT 3
- When to support net6.0 platform? HOT 2
- PublishSingleFile causes Target symbol-name is unknown: 'RichTextBox' HOT 16
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nlog.windows.forms.