Giter Site home page Giter Site logo

Comments (3)

Fr33dan avatar Fr33dan commented on July 21, 2024

I wanted to do something productive this morning and thought I would give this a whack. ToolStripMenuItemTarget and MessageBoxTarget's already support them, FormControlTarget was trivial to update, but layoutable properties has some larger implications for the RichTextBoxTarget.

RichTextBoxTarget was designed with the presumption that each target would specify a single RichTextBox. If the control and form name are Layout's instead of fixed strings, there is the possibility that the layout could render differently each time the same target is used and the 1 to 1 contract of target to RichTextBox is broken.

The target can still be reworked to find/create the appropriate RichTextBox on each log call, but this is a significant change to functionality.

The object references to the target's form and RichTextBox would have to be removed, as well as the static functions to find RichTextBoxTarget from a RichTextBox. The tests rely on these and would have to be reworked and could impact any users who might be using these.

I'm inclined to say it's worth it to add the flexibility of layoutable properties, but given y'alls rigorous testing strategy, maintaining compatibility could be a higher priority.

from nlog.windows.forms.

304NotModified avatar 304NotModified commented on July 21, 2024

The target can still be reworked to find/create the appropriate RichTextBox on each log call, but this is a significant change to functionality.

We could still use layouts, but only support them when doing a new initialize or something like that.

from nlog.windows.forms.

304NotModified avatar 304NotModified commented on July 21, 2024

I wanted to do something productive this morning and thought I would give this a whack. ToolStripMenuItemTarget and MessageBoxTarget's already support them, FormControlTarget was trivial to update, but layoutable properties has some larger implications for the RichTextBoxTarget.

Thanks for that!

from nlog.windows.forms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.