ordered json pointer corruption

[mishase]

ordered json pointer corruption

[nlohmann]

This seems related to #4279.

[gregmarr]

As in the linked issue, you can't do that. The push_back function on vector can invalidate pointers, and ordered_json uses a vector.

[mishase]

It is related to the issue you mentioned earlier, but it's certainly NOT a documentation issue. ordered_json must have working push_back function without any pointer corruption or this function must be private if it can cause such behaviour. Please fix this

[nlohmann]

I have no idea how to fix it, so documentation is currently all we can do.

[gregmarr]

@mishase This behavior comes from std::vector<>::push_back(), so not only is it not broken, it is standards conforming.

https://en.cppreference.com/w/cpp/container/vector/push_back

If after the operation the new size() is greater than old capacity() a reallocation takes place, in which case all iterators (including the end() iterator) and all references to the elements are invalidated. Otherwise only the end() iterator is invalidated.