Fix Open API document generated by Hakunapi and used by demo service

[teezip]

Fix Open API document generated by Hakunapi and used by demo service

[jampukka]

This should be fixed by #71 (at least according to my manual and integration tests)

[teezip]

Thanks. Tested by setting up demo service on a local machine from features.war build from latest code in main (that should have #71 merged). The demo service on a local machine give Open API document that is OK according to Swagger editor, but still one error: Structural error at info.contact.email because by default email address is empty string '' in demo conf.

This is not a bug in Hakunapi, but in configuration of demo application.

When removing api.contact.email from addresses.properties it results in Open API document with info.contact.email to be 'N/A'. Swagger editor complains about this too.

Maybe it would be better to leave an optional info.contact.email element out of Open API output if not set in conf file?

Anyway when setting api.contact.email in conf as a valid formatted email address then demo service returns an Open API document that can be viewed without complaints in Swagger editor too.

[teezip]

Maybe instructions in https://github.com/nlsfi/hakunapi/tree/main/examples/finnish_addresses in section "Preparing for production" could ask installers of demo service to set their contact information (including that info.contact.email) to get Open API document that Swagger Editor swallows too...

[jampukka]

Allowed null/missing contact information to omit the contact element from OpenAPI description altogether in #75. Changed finnish_addresses example to reflect that and added a note about setting proper contact values in "Preparing for production" section