Giter Site home page Giter Site logo

Comments (7)

fossell avatar fossell commented on August 18, 2024

@DusanJovic-NOAA - while some of these may be old and not used for any application, others are necessary for building EMC_post in a standalone manner or for operational use (e.g. makefile, makefile_dtc, makefile_module). Our vision is that we will support standalone versions of UPP from release/public-v* branches so that community can use the same code within and outside any UFS app. Even if we don't do that, my preference would be that we retain makefiles required for community and operational use, even if not used by UFS apps, so that the repo and all its branches can remain in sync. This is will help facilitate code community code contributions in the future as well.
@WenMeng-NOAA - Do you agree?

from upp.

WenMeng-NOAA avatar WenMeng-NOAA commented on August 18, 2024

I agree with @fossell. Right now we use makefile_module to build UPP executable for our UPP standalone test. The makefile_module is also used by ops. and emc gfs workflow and other application's workflow. The makefile_lib is used for building post library. We might delete some obsolete makefile from Dusan's list.

from upp.

DusanJovic-NOAA avatar DusanJovic-NOAA commented on August 18, 2024

I'm talking about release/public-v8 branch which is not used in production. Is emc gfs workflow using this branch?

from upp.

fossell avatar fossell commented on August 18, 2024

@DusanJovic-NOAA Yes I understand you mean just release/public-v8 branch, but removing all of them means that a user will not be able to build that branch outside of the app. While that's ok right now, future vision is to have that possibility.
Most importantly though, I do not think it is wise to let release/public-v8 branch diverge from develop in this manner. This will not be consistent with our code management plan.

I would ok removing the following makefiles with @WenMeng-NOAA's approval as well:
makefile_nems
makefile.sh
makefile_wcoss
makefile_LINUX
makefile_Linux_gnu
makefile_Linux_intel
makefile_Linux_pgi

But these makefiles should remain:
makefile_dtc
makefile_lib
makefile_module

from upp.

WenMeng-NOAA avatar WenMeng-NOAA commented on August 18, 2024

The emc gfs workflow does not use release/public-v8. If you keep makefile_module and makefile_lib, it would be good for me to run UPP standalone test for trouble-shooting UPP related issues.

from upp.

WenMeng-NOAA avatar WenMeng-NOAA commented on August 18, 2024

@fossell 's proposal makes sense to me.

from upp.

DusanJovic-NOAA avatar DusanJovic-NOAA commented on August 18, 2024

Fixed in 3f8a4b8

from upp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.