Comments (13)
Hi @CarstenHansen do you have any progress to report on this issue? Thanks.
from ww3.
Hi @ajhenrique. I am waiting, with patience, for hopefully critical feed-back from @ukmo-ccbunney and @ukmo-ansaulter.
The feedback is needed because 1) it is possible at run an SMC model with the /RTD switch, 2) they made the 2018 enhancements that makes my enhancement possible, and 3) ww3_ounf.ftn becomes more complex because the suggested enhancement allows a standard lat-lon model to be set up with the /RTD switch.
Maybe also I should learn to run run relevant regtests?
from ww3.
Hello @CarstenHansen ,
I'm sorry I have not had a chance to have a proper look at this yet - I've been a bit snowed under since returning from 5 weeks parental leave! I'm working on a PR at the moment to fix some bugs that are stopping the Met Office from achieving our Trusted Institutional Fork status. Once this is sorted, @ukmo-ansaulter or myself will review of your feature branch ASAP!
Regards,
Chris.
from ww3.
Hi @CarstenHansen . @ukmo-ccbunney and I have looked through the changes you've proposed. The concept and code changes seem fine, although I have added one comment regarding the logic in ww3_ounf.ftn for you to look at.
There is probably a requirement for some further testing (maybe we need to run your code with our rotated grid models for a comparison) and an update to the manual (as this option means we need to compile a standard grid model with /RTD if any of the nested models are rotated).
from ww3.
Thank you @ukmo-ansaulter and @ukmo-ccbunney for looking this through. I agree with your comment that there should be no special logical conditions in ww3_ounf.ftn in case you are running an SMC grid. I will appreciate if you try to run my code in a rotated grid model of yours. Especially if you run an SMC grid model for which I have no experience.
from ww3.
@ukmo-ansaulter and @ukmo-ccbunney: I agree there should be additional three or four sentences in the manual stating three additional points:
- With RTD in the switch file, output b. c. to one or more nested grids, being either rotated or standard lat-lon, can be written to files nestI.ww3 by specifying in the namelists the latitude and longitude of each nested file.
- When applying the boundary conditions from such a file to a model on a standard lat-lon grid, the RTD switch is not required in compiling the executables for that model.
- Without the compile switch RTD it is still possible (I think) to output to out_pnt.ww3 the wave spectra in the individual nesting grid points and pre-process these data for the nested run using the programs ww3_ounp and ww3_bounc or ww3_bound (this must be more precise - I havn't tried this procedure).
from ww3.
Hello @CarstenHansen ,
I have run a test using your fb_rtd2
branch on our Global configuration and nested Atlantic Margin Model (AMM; formulated on a rotated pole). I have also run the same configurations using the develop
branch as a control.
The results confirm that the nest files are the same between the develop
and fb_rtd2
branches (using WW3_BOUND to check the indices and interpolation coefficients of the boundary spectra).
The only difference is in the output netCDF file for the non-rotated SMC global model: this contains attributes and variables relating to the rotated pole that should not be there; this was expected and discussed in the comments above.
When you have made the changes discussed in previous comments, I will rerun the test again. However, it all looks pretty good from our end! Nice work.
One small related comment (and not an action on you): I notice that when running the WW3_GRID program with the !/O2
switch (to produce a list of input boundary locaitons), the output is missing for grids using the SMC scheme. This is due to the way that the boundary points are dealt with internally by the SMC code. We have SMC grid generation tools here at the Met Ofice (which we intend to share with the wider community) that do provide a list of boundary points as part of the output, but it is worth noting that the method described in the manual will not work for SMC grids.
from ww3.
Thank you @ukmo-ccbunney, I am very happy to see this.
I have removed the condition ' .OR. SMCGRD' in the two paces in ww3_ounf.ftn that cause the wrong NetCDF attributes related to a rotated pole (noticed by @ukmo-ansaulter) and I have push'ed a new commit ddbaa87 also including simplifications to a few comments.
from ww3.
I will dig into the manual and suggest the few necessary updates to sections 4.4.9 Rotated grids, G1.1 ww3 grid.inp, and G.1.2 ww3 grid.nml. Also check for consistency with Sect. B1, step (4) in the instructions for setting output boundary conditions.
from ww3.
Hi @ukmo-ccbunney and @ukmo-ansaulter. I have modified the manual (file manual/num/rotagrid.tex and pushed to commit CarstenHansen@6a0ffac.
I think Jian-Guo Li should be consulted to see if the text reads OK.
I have kept the reference to the traditional format of input file ww3_grid.inp, not mentioning the 'new' format ww3_grid.nml. This is because the example in manual Sect. G.1.2 does not show how to define the namelists ROTD and ROTB, but only how to define the containing filename GRID%NML= ’namelists.nml’. This seems to be a separate issue with the manual, since that file also contains the example of an ’Out of the box’ test setup.
from ww3.
Here is a print of the two pages modified: manual_pp151-152.pdf
from ww3.
@CarstenHansen - that all looks very sensible to me.
Cheers, Chris.
from ww3.
Incorporated in Pull request "UKMO Staging [fb_rtd2, bf_coupling condition, bf_smc_omp]" #254
from ww3.
Related Issues (20)
- The recent commit 629d27a has added a Github actions file (regtest_gnu) that fails with a syntax error message HOT 4
- Assistance with Converting ERA5 & WRF Model Simulated Wind Fields to WW3 Input Format HOT 3
- Compile time error using 'S' switch
- ERF coupling with WW3 (MPI communicator assumptions) HOT 7
- Update/fix NCEP regtests for Rocky9 OS on Orion
- w3_automake bug HOT 2
- Investigate difference in netcdf files regarding Orion Rocky9 regtest updates
- gx_outp does not work in test case: ww3_ts1
- Be able to handle point output if point/grid mismatch because -180 to 180 vs 0 to 360
- Restart does not work for some cases using the unstructured scheme HOT 9
- Source terms output broken in ww3_ounp.F90
- Quadtree adaptive WW3 HOT 1
- The
- trho(2) not set in w3iorsmd HOT 2
- Time origin and filename for netcdf gridded output in mesh cap is incorrect
- Units for several fields in netcdf output via the mesh cap are incorrect.
- Additional export fields need to be provided by mesh cap for coupling with SCHISM in the UFS-Coastal app.
- ww3_prnc not able to handle NaN as fillvalue
- ww3_prnc not able to handle curv grid for unst mesh
- Add netcdf restart and history files using PIO (parallel netCDF) for dev/ufs-weather-model HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ww3.