Giter Site home page Giter Site logo

Comments (2)

nikizadehgfdl avatar nikizadehgfdl commented on July 20, 2024

@ceblanton or @ngs333 can you please assign this issue to me since I am working on it.

from fre-nctools.

nikizadehgfdl avatar nikizadehgfdl commented on July 20, 2024

I found the root cause. The fix I made for poly_area in issue #45 produces the corrected value for area in grid cells that straddle the South Pole that would otherwise be 25% of the area of the Earth.
But, the function poly_ctrlat() in create_xgrid.c which is called by frergid --conserve_order2 has a similar bug for those grid cells and comes up with a vastly wrong latitude for the centroid of those grid cells. However since ctrlat is devided by cell_area in fregrid calculations the two nonsense huge values (for incorrect area and ctrlat) used to cancel each other out and fregrid would end up with a finite value.
After my fix to poly_area the cancellation would not happen and we end up with very wrong (huge negative) values for otherwise positive quantities (e.g., olr) for the few grid cells around the South Pole.
The fix is simply to do the same fix I did for poly_area() in poly_ctrlat().

In my opinion the fregrid estimates are not accurate at the South Pole cells for stretched grids, with or without any of my fixes. It's only that the values make sense after I put the fix in both poly_area and ctrlat, or without either of the fixes (as in bronx-18).

from fre-nctools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.