Giter Site home page Giter Site logo

Comments (4)

NoamELB avatar NoamELB commented on June 8, 2024

Yes, great idea!
Will do 😁

Edit: Just note that you need to pass current state & prop
so it will be more like this:

export function shallowEqual(thisProps, nextProps, thisState, nextState) {
    return !shallowEqualState(thisState, nextState) || !shallowEqualWithoutReactElements(thisProps, nextProps);
}

from shouldcomponentupdate-children.

mnpenner avatar mnpenner commented on June 8, 2024

Is that really necessary? If you use the context (this) directly then we can just do

class MyComponent extends React.Component {
    shouldComponentUpdate = shouldComponentUpdateChildren;
}

And the magic of JavaScript will pass the context along. Barring that, one can manually pass it via .call or the :: bind operator.

from shouldcomponentupdate-children.

NoamELB avatar NoamELB commented on June 8, 2024

I get what you mean, I will just add both 😅

from shouldcomponentupdate-children.

mnpenner avatar mnpenner commented on June 8, 2024

Coolbeans 😄 Thanks!

from shouldcomponentupdate-children.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.