Twig 3 Compatibility

[nochso]

Twig 3 Compatibility

[toxpal]

Sorry, my bad, I used it earlier (can't remember the reason, but I had to look for another solution), and switched to https://packagist.org/packages/voku/html-compress-twig later

[MarelPup]

It's ok, i had already moved to a homemade solution when writing my first comment , i think i'll use this solution

[StasToken]

I am also interested in this question, I spent all day today trying to find something similar on the Internet, but not a single analogue can twig 3

[antiftw]

Hi @nochso

Bump, since I've been having the same problem migrating my cms to Symfony 5, which uses twig 3.0 ;) Have spent multiple days now looking for something with similar functionality and that also works without much hassle, without any success.

Thanks in advance,

PS. I don't even mind doing so myself, since I have the idea there are no major changes required, just a version bump, or am I wrong and are you dreading the day to start the rewrite?? haha ^^ Have never worked with submitting anything myself to packagist/github so you would have to give me some pointers where to start ;)

[ekyazilim]

Hi @nochso
I'm eagerly awaiting the upgrade to twig 3. thanks..

[MarelPup]

Hi @nochso
the repo is silent since 2017 ,
is our best option implementing the dependency
https://packagist.org/packages/wyrihaximus/html-compress
using kernel.response as such ?
https://stackoverflow.com/a/72082233
https://symfony.com/doc/current/event_dispatcher.html#before-filters-with-the-kernel-controller-event

[toxpal]

Yes, I switched to the solution mentioned above (wyrihaximus/html-compress) earlier, but it doesn't minify inline JavaScript code...

[MarelPup]

strange, considering

    public function __construct($forceCompression = false)
    {
        $this->forceCompression = $forceCompression;
        $this->parser = Factory::constructSmallest();
        $this->callable = array($this, 'compress');
    }

    public function compress(Twig_Environment $twig, $html)
    {
        if (!$twig->isDebug() || $this->forceCompression) {
            return $this->parser->compress($html);
        }
        return $html;
    }

doesn't seem to be a different implemetation of wyrihaximus ' basic compression

[toxpal]

If I understand right, you use wyrihaximus/html-compress as a base + some custom code?

[MarelPup]

yes, I use kernel.response , as cited in the stackoverflow link