Giter Site home page Giter Site logo

Comments (8)

SimenB avatar SimenB commented on June 14, 2024 1

Never heard of volta, but: https://nodejs.org/download/nightly/

from citgm.

novemberborn avatar novemberborn commented on June 14, 2024 1

This is the same issue as discussed in nodejs/node#50138. It'll be fixed in AVA 6 but tests will fail until that is out, and I cannot provide a timeline on that.

See also avajs/ava#3251.

from citgm.

novemberborn avatar novemberborn commented on June 14, 2024

@alfonsograziano the AVA tests that are failing have to do with deterministic snapshot generation. It seems in the commit-under-test, the snapshots are 8 bytes larger. This is unexpected. I'm not sure how to run AVA against this specific commit to figure out why though.

Scanning through the Jose failures it also looks like some binary mismatch. So this could be a genuine issue with this Node.js build.

from citgm.

alfonsograziano avatar alfonsograziano commented on June 14, 2024

Based on the Jose issue (#1011) the maintainer changed the package to make some tests non-deterministic. I'm not sure if this is the case.

You can get some other insights on Jose here: nodejs/node#50138

Can you please try to build Node.js locally and verify if you're able to reproduce the issue? Would be really helpful to understand if this is a problem with the package or a bug in the Node.js build

from citgm.

SimenB avatar SimenB commented on June 14, 2024

Installing the nightly is probably easier than building from source, FWIW 🙂

from citgm.

novemberborn avatar novemberborn commented on June 14, 2024

I'll need some pointers on how to access the nightly, ideally using Volta.

from citgm.

novemberborn avatar novemberborn commented on June 14, 2024

The citgm report is now under security embargo.

I ran AVA's tests using https://nodejs.org/download/nightly/v21.0.0-nightly20231009387e2929fe/ on macOS and they passed.

One thing that comes to mind is that the binary data that AVA's tests are failing for is gzip compressed so perhaps there's a change there?

from citgm.

alfonsograziano avatar alfonsograziano commented on June 14, 2024

Thanks a lot for the update :)
Will keep this issue open until AVA 6 gets released

from citgm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.