Giter Site home page Giter Site logo

Comments (5)

lukekarrys avatar lukekarrys commented on May 11, 2024 1

Somebody with write privileges to the repo would however need to edit the release text on node-gyp v10.0.0 separately to complete the resolution of this issue I guess.

Thanks for the reminder there, I went ahead and removed that line in the release.

from node-gyp.

lukekarrys avatar lukekarrys commented on May 11, 2024

Good catch, that's because v10 did include two separate commits changing the node version since v10 was in development for awhile.

@MikeMcC399 Do you want to open a PR removing the incorrect version from the changelog?

from node-gyp.

MikeMcC399 avatar MikeMcC399 commented on May 11, 2024

@lukekarrys

Do you want to open a PR removing the incorrect version from the changelog?

I will submit a PR for the CHANGELOG.

Somebody with write privileges to the repo would however need to edit the release text on node-gyp v10.0.0 separately to complete the resolution of this issue I guess.

from node-gyp.

MikeMcC399 avatar MikeMcC399 commented on May 11, 2024

from node-gyp.

MikeMcC399 avatar MikeMcC399 commented on May 11, 2024

Thanks @lukekarrys !

  • The original issue I reported is now resolved. The related issue in the CHANGELOG is covered by PR #2938.

from node-gyp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.