Add regression tests

[nodejs]

Add regression tests

[TooTallNate]

Ya I like the bot and it would be cool to get it set up (though frankly I don't get a lot of pull requests for this project :p ). node-gyp doesn't currently have a test suite, do I need to add one to bot.io? Also, any reason I can't just set it up on my server I'm running at home on some arbitrary port?

[arturadib]

Actually you can totally set it up at home (provided your IP is fixed).

You will need to write some unit tests and a simple shell-like script that tells the bot how to run the tests. (The scripts are written using ShellJS). Check out the README for examples.

[TooTallNate]

(provided your IP is fixed)

It's not, but I have dynamically updating hostnames, so I assume that's good enough, ya?

You will need to write some unit tests and a simple shell-like script that tells the bot how to run the tests. (The scripts are written using ShellJS). Check out the README for examples.

Ok will do. It would be good for node-gyp to have some basic tests anyways.

[arturadib]

It's not, but I have dynamically updating hostnames, so I assume that's good enough, ya?

It's amazing how quickly what I thought would be edge cases actually
become average cases -- Bot.io doesn't currently support host names.
(Its bootstrap process automatically detects the public IP of the
machine and sets Github hooks accordingly).

I need to create a new option... Hang on, will report back.

[arturadib]

I need to create a new option... Hang on, will report back.

Done! The README has been updated with the new installation steps:

https://github.com/arturadib/botio

Let me know if you run into any difficulties.

[Trott]

@nodejs/node-gyp Should this issue remain open? I imagine that after nearly 6 years of no activity, there's a high likelihood (but not certainty) that it no longer applies or is a will-not-fix issue or something like that.

[bnoordhuis]

I'll close. We have tests and CI now.