Giter Site home page Giter Site logo

IMAP handlers and commands should be consistent in the naming convention of `code` and `responseMessage` (similar to `smtp-server`) about wildduck HOT 3 CLOSED

titanism avatar titanism commented on June 19, 2024
IMAP handlers and commands should be consistent in the naming convention of `code` and `responseMessage` (similar to `smtp-server`)

from wildduck.

Comments (3)

andris9 avatar andris9 commented on June 19, 2024

These values have different meanings, so yes it can be quite confusing. In some places, these are used invalidly as well, which adds to the confusion. SMTP is different from IMAP as IMAP is a richer protocol, so the same conventions do not work so well. The main difference is that SMTP always yields a single response, but IMAP can return any number of responses - one final tagged response and multiple untagged responses.

  • err.imapResponse is for IMAP response codes - these are standardized values
  • err.response is human readable error message - this can be whatever
  • err.responseMessage and err.response should probably be the same thing

from wildduck.

titanism avatar titanism commented on June 19, 2024

Thank you for the clarification, we're slowly learning more! 🙇

from wildduck.

titanism avatar titanism commented on June 19, 2024

Perhaps update err.responseerr.responseMessage in the codebase? (per your last bullet point)

from wildduck.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.