Giter Site home page Giter Site logo

Comments (3)

acaloiaro avatar acaloiaro commented on September 18, 2024

I've suggested a fairly naive fix that I welcome feedback on: #14

I call this naive because using the first directory from sys.path suffixed with DLLs is not what I consider production-worthy. This should be considered nothing more than a proof-of-concept. Note, I have attempted to fix the issue with find_library by first calling os.add_dll_directory with the path to the system DLLs directory, to no avail.

from dedrm_tools.

noDRM avatar noDRM commented on September 18, 2024

Thanks for that issue report / PR.

I was unable to get it to correctly find that DLL under Wine either, no matter what I tried.

I did test Wine key retrieval in the past without issues, but I probably had Crypto(dome) installed and it used that instead of OpenSSL.
Your solution with checking if the path ends with "DLLs" sounded rather hack-y and unreliable, so I instead implemented it in a way to just check all folders in the PATH variable and check if the DLL is actually present in one of them, that should be way more reliable.

Also, I noticed that the non-OpenSSL code only tried to use Crypto and not Cryptodome and just quickly fixed that, too.

I'm going to close your PR without merging it, but I've added you as author of my commit d4eddbc with the bugfix. Thanks!

If there's any more issues under Wine, feel free to re-open this.

from dedrm_tools.

acaloiaro avatar acaloiaro commented on September 18, 2024

Sounds good. The exhaustive sys.path check is a sensible approach.

from dedrm_tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.