Capability to return a BytesIO/filelike even if it isn't encrypted?

[CDWimmer]

Capability to return a BytesIO/filelike even if it isn't encrypted?

[nolze]

Thanks for your suggestion!
I think adding a utility function (as a context manager) similar to your decrypt_office_file() to the library is a good idea and will do it.
In the case of your code example, I might replace decrypted_file = file with decrypted_file = BytesIO(f) so that the function always returns BytesIO.

I also find it really odd that .decrypt() takes the object you want to inject the file into as an argument, rather than returning a BytesIO object? It makes following the code flow feel awkward to me, but that's a for another day!

I understand. The problem is that always creating a BytesIO object can consume unnecessary memory, especially if the document is large in file size.

[954-Ivory]

Thanks for your suggestion! I think adding a utility function (as a context manager) similar to your decrypt_office_file() to the library is a good idea and will do it. In the case of your code example, I might replace decrypted_file = file with decrypted_file = BytesIO(f) so that the function always returns BytesIO.

Brilliant, I just threw that together to get what I needed, I'm sure you'll make it better 😄

I understand. The problem is that always creating a BytesIO object can consume unnecessary memory, especially if the document is large in file size.

~ snip ~ I wrote a load of nonsense, I'm sure you know what you're doing! Plus, this way can support alternatives to just BytesIO which is nice, I guess you could with open as f and pass f as ofile!

There will probably be a lot of people like me who forgot to f.seek(0) 😂.

with open(file_path, 'rb') as f:
    file = msoffcrypto.OfficeFile(f)
    if file.is_encrypted():
        file.load_key(password=password)  # Use password
        file.decrypt(decrypted_io)
    else:
        f.seek(0) # don't forget this
        decrypted_io.write(f.read())
return decrypted_io

[CDWimmer]

Thanks for your suggestion! I think adding a utility function (as a context manager) similar to your decrypt_office_file() to the library is a good idea and will do it. In the case of your code example, I might replace decrypted_file = file with decrypted_file = BytesIO(f) so that the function always returns BytesIO.

Brilliant, I just threw that together to get what I needed, I'm sure you'll make it better 😄

I understand. The problem is that always creating a BytesIO object can consume unnecessary memory, especially if the document is large in file size.

~ snip ~ I wrote a load of nonsense, I'm sure you know what you're doing! Plus, this way can support alternatives to just BytesIO which is nice, I guess you could with open as f and pass f as ofile!