Resource IDs should have constants

[nomorefood]

Resource IDs should have constants

[NoMoreFood]

Agree with your comment, generally speaking. If I had any control of the upstream code (PuTTY), I would definitely change it. And like 100 other things -- I'm definitely not a fan of the PuTTY codebase (e.g., terrible indenting, lots of correctable warnings in Visual Studio). Being that I don't have control of upstream code, I try to follow the axiom of only making delta changes in the code style / technique of the original file even if those aren't best practices. While it may introduce room for error as you indicated, so does making larger changes to sections of code we'll have to try to merge later. If you can convince the maintainers of PuTTY to make the corresponding changes in the upstream first, PuTTY CAC will gladly adapt.

The only thing I see wrong in the second link is the comment next to the case statement -- which I will fix. Please let me know if you see something else.

[GigabyteProductions]

I suspected that you were just trying to stick with what upstream does, but applying best practice to new code is also doable here ("Add PKCS Cert", "Add CAPI Cert", and their IDs are "new" to upstream Putty).

Regarding the second link: Yes; I was referring to the comments. I do understand there is no functional difference between the comment or case order, but I thought it was at least notable. That kind of thing has potential to cause issues in development, because of people of applying their code around what the comment says and nobody noticing it's wrong.

[NoMoreFood]

Addressed in latest commit (5f74bce).