Giter Site home page Giter Site logo

Comments (5)

liranmauda avatar liranmauda commented on May 27, 2024

I guess we can do something like:

async function _get_dns_servers_in_forwarders_file() {
        if (!IS_LINUX_VM) return [];
        try {
            const line = await fs_utils.find_line_in_file(config.NAMED_DEFAULTS.FORWARDERS_OPTION_FILE, 'forwarders');
            if (!line) return [];
            const dns_servers = line.match(/\b\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}\b/g);
            return dns_servers || [];
        } catch (e) {
            dbg.warn('_get_dns_servers_in_forwarders_file got error:', e);
            return [];
        }
}

@guymguym WDYT?

from noobaa-core.

guymguym avatar guymguym commented on May 27, 2024

Looks good @liranmauda !

from noobaa-core.

guymguym avatar guymguym commented on May 27, 2024

One comment is that we don't want this to warn (or even log) every time we call it - logging once is more than enough :)

from noobaa-core.

guymguym avatar guymguym commented on May 27, 2024

@nimrod-becker can this be assigned?

from noobaa-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.