Giter Site home page Giter Site logo

Comments (13)

noodlehaus avatar noodlehaus commented on August 23, 2024

hi giordanovi. i've looked through the code and i can't find any array declaration that uses the 5.4 array syntax, even on the line numbers you gave (22 and 490).

from dispatch.

giordanovi avatar giordanovi commented on August 23, 2024

Really?!
I've installed Dispatch through composer. At line 22 i've this code:
static $error_callbacks = [];

from dispatch.

noodlehaus avatar noodlehaus commented on August 23, 2024

a i see. let me check. the tag referenced by composer may have not been updated.

from dispatch.

noodlehaus avatar noodlehaus commented on August 23, 2024

i've just updated the github tags, should reflect on composer in a few minutes.

from dispatch.

giordanovi avatar giordanovi commented on August 23, 2024

I still can not see the change. Re-installing the package not solve and still download the incorrect version.

from dispatch.

noodlehaus avatar noodlehaus commented on August 23, 2024

the version version it should download is 4.0.9. i've just tried it and the correct version got downloaded. but I didn't have a composer.lock file to begin width so composer got the latest for me.

from dispatch.

giordanovi avatar giordanovi commented on August 23, 2024

Composer downloads version 1.1.6. If I force download version 4.*, It say me that dispatch/dispatch 4.0.9 requires php >= 5.4.0.

from dispatch.

noodlehaus avatar noodlehaus commented on August 23, 2024

Sorry for the mix up. Yes, dispatch has always required 5.4 if being installed via composer. Code-wise, it can run in 5.3 though if you manually include the source or point to a fork with the updated composer.json.

from dispatch.

scan avatar scan commented on August 23, 2024

Though I wonder why not just set the php-version to 5.3 in the composer.json if you support it anyway?

from dispatch.

noodlehaus avatar noodlehaus commented on August 23, 2024

my reason for requiring 5.4 is i was really hoping to stop supporting 5.3 :D but yeah, it doesn't really make sense since 5.3 is very much mainstream, and we have already put in every effort to make sure this works in 5.3, barring the tests. ok guys, i'll update and make this require 5.3 instead.

from dispatch.

bmcminn avatar bmcminn commented on August 23, 2024

Everyone should bump up to 5.4+ because of the numerous optimizations and security plugs the PHP team has rolled out since 5.3. Also bracket style array syntax! :D

from dispatch.

scan avatar scan commented on August 23, 2024

The problem is most servers (like ours) use Ubuntu 12.04 LTS, which comes with PHP 5.3. It's not easy to change that.

As long as 14.04 isn't mainstream, supporting PHP 5.3 officially will help dispatch become more popular for production, in my opinion.

from dispatch.

rmasters avatar rmasters commented on August 23, 2024

Going a bit off-topic, but it's not too hard to get 5.4/5.5 on 12.04 using a PPA:

sudo add-apt-repository ppa:ondrej/php5
# or ppa:ondrej/php5-oldstable for 5.4
sudo apt-get update
sudo apt-get upgrade

These are produced by the same people who maintain the Debian upstream PHP package.

from dispatch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.