Comments (9)
from identityserver4.ldapextension.
from identityserver4.ldapextension.
Sorry for late reply,
Pull requests can be done from your own repository. You first need to fork, then be on the latest version + do your changes and then pull... normally it will shows into the pull request list.
from identityserver4.ldapextension.
Please, also give a full detail for your user properties. A user without a username is a bit problematic ;).
I will require the steps to reproduce locally. Thank you.
from identityserver4.ldapextension.
FYI: I received pullrequest from peoeple who don't have any access.
from identityserver4.ldapextension.
I just ran into this very thing after spending many hours thinking I was screwing up the appsettings configuration. The bug is in the SetBaseDetails
method of ActiveDirectoryAppUser.cs
. If DisplayName attribute is not present on the Active Directory user, then NullReferenceException is thrown when StringValue
is accessed on line 130. A similar issue could happen with Username
on line 131.
The steps to reproduce for me were:
- Stand up Windows Server 2019 Core instance (performed using a Hyper-V VM)
- Promote to domain controller
- Create a user using Powershell:
New-ADUser -Name "testuser" -GivenName Test -SurName User -SamAccountName testuser -UserPrincipalName [email protected]
- Set password for user using Powershell:
Set-ADAccountPassword "CN=testuser,CN=users,dc=mydomain,dc=local" -Reset -NewPassword (ConvertTo-SecureString -AsPlainText "mypassword" -Force
- Enable the account:
Enable-ADAccount -Identity testuser
- Attempt to login using the Sample project and you will simply get a Invalid Username/Password.
I have not created a PR on github in the past but I can look at doing so.
from identityserver4.ldapextension.
Note: My PR does not handle UserName
attribute being null. I intentionally avoided changing that because if UserName
is null then SubjectId
won't be set and I think there will be a whole lot of other problems. Might be best to split that out into a separate issue and perhaps just update the returned error message (or at least log something better) that indicates something like "Required attribute 'UserName' is missing from the user's ActiveDirectory attributes."
from identityserver4.ldapextension.
I have same problem. @Nordes Please fix it.
from identityserver4.ldapextension.
Should now be available through Nuget.
https://www.nuget.org/packages/IdentityServer.LdapExtension/2.1.7
from identityserver4.ldapextension.
Related Issues (20)
- Add ReferralFollowing support
- What is possible with implementation of ILDAP User store? HOT 1
- Throws an error if UID attribute is not present in Active Directory HOT 1
- **401 Unauthorized** all the time HOT 2
- Async ILdapUserStore HOT 2
- groups/roles support HOT 2
- Is connection pooling implemented in this library HOT 1
- How to get data info from AD profiles like emails, name, etc from scopes? HOT 4
- Roadmap for support auf IdentityServer4 version 3.1.x and up HOT 1
- Build custom docker image HOT 1
- How to connect LDAP with GSS-API ?
- Problem with Configuration online-ldap ? HOT 3
- Roadmap to IdentityServer4 v4 HOT 1
- Is there a reset password feature here yet? HOT 1
- IdentityServer version 4.1.2 HOT 6
- Wrong AD user returns token in Docker container HOT 2
- invalid_grant and "User has been disabled"
- Support Duende Identity instead of just IdentityServer4 HOT 1
- Can you to show example with sso? HOT 2
- Low performance (in 100 times more) Connect/Bind methods in Docker on Win11 with Linux containers HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from identityserver4.ldapextension.