Comments (10)
Update:
I'm currently trying out a change for using async reconnection attempts.
Hopefully this will fix this problem, but I need to try it out a bit more.
from hiredis-cluster.
This relates with #19 and the conditions haven't changed since.
I guess you have a pretty low connect timeout already?
from hiredis-cluster.
Ya connect-timeout is set to 2seconds currently.
from hiredis-cluster.
So, a blocking connect() call will effectively see a max wait time of connect_timeout value, right?
And, if a poll() follows a connect(), i guess there too we will see a max of connect_timeout wait time. So, per redis server-ip there could be a 2*connect_timeout wait time in an error case.
from hiredis-cluster.
I'm not following you regarding the following poll()
? The poll() in hiredis is the one that handles timeout I though.
I guess the amount of outstanding callbacks add-on time, depending on max-retry-count.
If max-retry-count is higher then fewer callbacks triggers a config-get, so that might be a remedy..
from hiredis-cluster.
I'm not following you regarding the following
poll()
? The poll() in hiredis is the one that handles timeout I though.
what I meant was this piece of code, which follows after a failed connect() call.
https://github.com/redis/hiredis/blob/master/net.c#L266
from hiredis-cluster.
I'm not following you regarding the following
poll()
? The poll() in hiredis is the one that handles timeout I though.what I meant was this piece of code, which follows after a failed connect() call. https://github.com/redis/hiredis/blob/master/net.c#L266
Hope I made this clear @bjosv
from hiredis-cluster.
Thanks for the update @bjosv . Making the reconnection attempts async would really help in improving this wait period. Shall wait for the changes to retry the scenario.
from hiredis-cluster.
A change covering this issue is now delivered, hope it fixes the problems in your setup as well.
from hiredis-cluster.
Nice! Thanks, bjosv, shall try pulling this and see how it goes.
from hiredis-cluster.
Related Issues (20)
- return error when master node failover HOT 2
- Setting redis password for redisClusterAsyncContext HOT 2
- Problem to subscribe HOT 1
- Add test to verify correct handling of hostname in redirects HOT 1
- Behaviour when all redis nodes go down simultaneously. HOT 2
- When is the support for redis 7 coming? Any recommendation for which redis client to use for redis version 7? HOT 11
- Support custom commands defined in Redis modules HOT 6
- Testing fault tolerance HOT 1
- There is no way to perform AUTH in asynchronous mode. HOT 2
- Does hiredis-cluster support SSUBSCRIBE? HOT 2
- Compilation error LIBEVENT_INCLUDES-NOTFOUND HOT 3
- MOVED ERROR in pipeline-API when increasing shards in existing redis cluster HOT 10
- Target "hiredis::hiredis" because target "hiredis" is not a library HOT 1
- During cmake, Checking for module 'glib-2.0' No package 'glib-2.0' found HOT 2
- nodeNext strange behaviour after master failover. HOT 9
- With redisClusterAsyncCommandArgvToNode api, client not discovering new nodes on redis master node disconnect HOT 4
- Update the slotmap after send errors/timeouts in the sync API HOT 1
- hircluster.c:218:9: 错误: HOT 4
- Failed to find keys of command XREADGROUP HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hiredis-cluster.