Giter Site home page Giter Site logo

Comments (10)

bjosv avatar bjosv commented on July 27, 2024 3

Update:
I'm currently trying out a change for using async reconnection attempts.
Hopefully this will fix this problem, but I need to try it out a bit more.

from hiredis-cluster.

bjosv avatar bjosv commented on July 27, 2024

This relates with #19 and the conditions haven't changed since.
I guess you have a pretty low connect timeout already?

from hiredis-cluster.

rahulKrishnaM avatar rahulKrishnaM commented on July 27, 2024

Ya connect-timeout is set to 2seconds currently.

from hiredis-cluster.

rahulKrishnaM avatar rahulKrishnaM commented on July 27, 2024

So, a blocking connect() call will effectively see a max wait time of connect_timeout value, right?
And, if a poll() follows a connect(), i guess there too we will see a max of connect_timeout wait time. So, per redis server-ip there could be a 2*connect_timeout wait time in an error case.

from hiredis-cluster.

bjosv avatar bjosv commented on July 27, 2024

I'm not following you regarding the following poll()? The poll() in hiredis is the one that handles timeout I though.

I guess the amount of outstanding callbacks add-on time, depending on max-retry-count.
If max-retry-count is higher then fewer callbacks triggers a config-get, so that might be a remedy..

from hiredis-cluster.

rahulKrishnaM avatar rahulKrishnaM commented on July 27, 2024

I'm not following you regarding the following poll()? The poll() in hiredis is the one that handles timeout I though.

what I meant was this piece of code, which follows after a failed connect() call.
https://github.com/redis/hiredis/blob/master/net.c#L266

from hiredis-cluster.

rahulKrishnaM avatar rahulKrishnaM commented on July 27, 2024

I'm not following you regarding the following poll()? The poll() in hiredis is the one that handles timeout I though.

what I meant was this piece of code, which follows after a failed connect() call. https://github.com/redis/hiredis/blob/master/net.c#L266

Hope I made this clear @bjosv

from hiredis-cluster.

rahulKrishnaM avatar rahulKrishnaM commented on July 27, 2024

Thanks for the update @bjosv . Making the reconnection attempts async would really help in improving this wait period. Shall wait for the changes to retry the scenario.

from hiredis-cluster.

bjosv avatar bjosv commented on July 27, 2024

A change covering this issue is now delivered, hope it fixes the problems in your setup as well.

from hiredis-cluster.

rahulKrishnaM avatar rahulKrishnaM commented on July 27, 2024

Nice! Thanks, bjosv, shall try pulling this and see how it goes.

from hiredis-cluster.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.