Giter Site home page Giter Site logo

Comments (6)

arcticicestudio avatar arcticicestudio commented on May 19, 2024 2

Thanks for your contribution 👍
I'll see how to improve the recognizability of the selected text on the current line, maybe the selection will be brighter to stand out from the background color.

Regarding the comment color: There is nordtheme/nord#94 that deals with improving the contrast of comments for all port projects. It'll be implemented for this project as soon as the decision has been made.

from jetbrains.

axelitus avatar axelitus commented on May 19, 2024 1

Awesome! Can't wait for it, so far the theme is just incredible! I'm using it everywhere: PhpStorm, Sublime Text, Vim, Gnome Terminal...

Thanks for creating it!

from jetbrains.

axelitus avatar axelitus commented on May 19, 2024 1

@arcticicestudio great to hear! Hopefully, JetBrains gets this done, as it is a nice idea that would great without messing up with the color palette. I've given it the first thumbs up!

from jetbrains.

seraphlive avatar seraphlive commented on May 19, 2024

I find "snowstorm" region highlight style in the Emacs version of Nord theme looks kind of cool. I'm thinking maybe we can use that as a reference. Just not sure if it can be easily implemented in jetbrain's editors. :)

(another way may be disable current line highlight when some block of codes are selected, like in vscode)

from jetbrains.

arcticicestudio avatar arcticicestudio commented on May 19, 2024

@seraphlive Unfortunately there is no way to implement theme configurations since all definitions are simply XML and JSON files. It is not possible to implement any logic like functions for conditions based on user configurations. Emacs on the other hand are defined in Lisp so they can implement logic based on settings made by the user.

@axelitus The comment color contrast was finally increased in #41 and released in version 0.4.0. I'll close this issue for now until there is either a way to implement theme configurations or the background color of the currently active cursor line can make use of color opacity (alpha layer).

from jetbrains.

arcticicestudio avatar arcticicestudio commented on May 19, 2024

@axelitus I've submitted IDEA-215064 that requests an implementation of the highlighting feature like in VS Code: Hide the background color of the active line when selecting text.

from jetbrains.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.