Angular Sample: $digest already in progress

[northwoodssoftware]

Angular Sample: $digest already in progress

[WalterNorthwoods]

That's a flaw in the sample. The problem is that replacing the Diagram.model may change the selection, which will result in a call to scope.$apply() at a time when that apparently is undesirable.

So change the "ChangedSelection" DiagramEvent listener to be:

          // update the model when the selection changes
          function updateSelection(e) {
            var selnode = diagram.selection.first();
            diagram.model.selectedNodeData = (selnode instanceof go.Node ? selnode.data : null);
            scope.$apply();
          }
          diagram.addDiagramListener("ChangedSelection", updateSelection);

and then make the model-watching listener smarter:

          // notice when the value of "model" changes: update the Diagram.model
          scope.$watch("model", function(newmodel) {
            var oldmodel = diagram.model;
            if (oldmodel !== newmodel) {
              diagram.removeDiagramListener("ChangedSelection", updateSelection);
              diagram.model = newmodel;
              diagram.addDiagramListener("ChangedSelection", updateSelection);
            }
          });

Alas it is too late for this change to go into the 1.6.5 release, which is partly released already. When master has been updated here, I'll update the samples/angular.html file.