Giter Site home page Giter Site logo

Comments (10)

sajayantony avatar sajayantony commented on August 16, 2024

I believe the tag names have to be prefixed with v and similarly recommend prefixing the v for release as well similar to https://github.com/kubernetes/kubernetes/releases/tag/v1.22.2

from notation-go.

sajayantony avatar sajayantony commented on August 16, 2024

+1

from notation-go.

SteveLasker avatar SteveLasker commented on August 16, 2024

+1

from notation-go.

sajayantony avatar sajayantony commented on August 16, 2024

@iamsamirzon - The candidate commit is - 6f3abd7

from notation-go.

SteveLasker avatar SteveLasker commented on August 16, 2024

LGTM 6f3abd7

from notation-go.

shizhMSFT avatar shizhMSFT commented on August 16, 2024

There is a issue in the version v1.0.0-alpha-1.

According to SemVer 2,

Precedence for two pre-release versions with the same major, minor, and patch version MUST be determined by comparing each dot separated identifier from left to right until a difference is found as follows:

Identifiers consisting of only digits are compared numerically.

Identifiers with letters or hyphens are compared lexically in ASCII sort order.

Numeric identifiers always have lower precedence than non-numeric identifiers.

A larger set of pre-release fields has a higher precedence than a smaller set, if all of the preceding identifiers are equal.

Example: 1.0.0-alpha < 1.0.0-alpha.1 < 1.0.0-alpha.beta < 1.0.0-beta < 1.0.0-beta.2 < 1.0.0-beta.11 < 1.0.0-rc.1 < 1.0.0.

it is better to have v1.0.0-alpha.1 than v1.0.0-alpha-1.

Here is a code example:

package main

import (
	"fmt"

	"golang.org/x/mod/semver"
)

func compare(s, t string) {
	switch res := semver.Compare(s, t); {
	case res < 0:
		fmt.Println(s, "<", t)
	case res == 0:
		fmt.Println(s, "==", t)
	case res > 0:
		fmt.Println(s, ">", t)
	}
}

func main() {
	compare("v1.0.0-alpha-2", "v1.0.0-alpha-11")
	compare("v1.0.0-alpha.2", "v1.0.0-alpha.11")
}

outputs:

v1.0.0-alpha-2 > v1.0.0-alpha-11
v1.0.0-alpha.2 < v1.0.0-alpha.11

from notation-go.

SteveLasker avatar SteveLasker commented on August 16, 2024

Regarding the versioning conversation from this morning:
To cut a release today, we'd like to propose:

  • Notary V2 standard (notaryproject-1.0.0-draft-1)
  • Notation Library (Version 0.5.0) (notation-go-lib-1.0.0-alpha-1)
  • Notation CLI (Version 0.6.1) (notation-1.0.0-alpha-1)
    Becomes - (changing the - to . and removing the notation --version reference)
  • Notary V2 standard (notaryproject-1.0.0-draft.1)
  • Notation Library (notation-go-lib-1.0.0-alpha.1)
  • Notation CLI (notation-1.0.0-alpha.1)

This would apply to

  • notaryproject/notaryproject specs
  • notaryproject/notation for the cli
  • notaryproject/notation-go-lib for the library

from notation-go.

dtzar avatar dtzar commented on August 16, 2024

@iamsamirzon @SteveLasker - I believe this is complete now...

All this said - It would be great to discuss release strategy and document something for ongoing work.

from notation-go.

iamsamirzon avatar iamsamirzon commented on August 16, 2024

I concur with your David.

from notation-go.

shizhMSFT avatar shizhMSFT commented on August 16, 2024

Closed as v0.7.0-alpha.1 has been released.

from notation-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.