Comments (10)
I believe the tag names have to be prefixed with v
and similarly recommend prefixing the v
for release as well similar to https://github.com/kubernetes/kubernetes/releases/tag/v1.22.2
from notation-go.
+1
from notation-go.
+1
from notation-go.
@iamsamirzon - The candidate commit is - 6f3abd7
from notation-go.
LGTM 6f3abd7
from notation-go.
There is a issue in the version v1.0.0-alpha-1
.
According to SemVer 2,
Precedence for two pre-release versions with the same major, minor, and patch version MUST be determined by comparing each dot separated identifier from left to right until a difference is found as follows:
Identifiers consisting of only digits are compared numerically.
Identifiers with letters or hyphens are compared lexically in ASCII sort order.
Numeric identifiers always have lower precedence than non-numeric identifiers.
A larger set of pre-release fields has a higher precedence than a smaller set, if all of the preceding identifiers are equal.
Example: 1.0.0-alpha < 1.0.0-alpha.1 < 1.0.0-alpha.beta < 1.0.0-beta < 1.0.0-beta.2 < 1.0.0-beta.11 < 1.0.0-rc.1 < 1.0.0.
it is better to have v1.0.0-alpha.1
than v1.0.0-alpha-1
.
Here is a code example:
package main
import (
"fmt"
"golang.org/x/mod/semver"
)
func compare(s, t string) {
switch res := semver.Compare(s, t); {
case res < 0:
fmt.Println(s, "<", t)
case res == 0:
fmt.Println(s, "==", t)
case res > 0:
fmt.Println(s, ">", t)
}
}
func main() {
compare("v1.0.0-alpha-2", "v1.0.0-alpha-11")
compare("v1.0.0-alpha.2", "v1.0.0-alpha.11")
}
outputs:
v1.0.0-alpha-2 > v1.0.0-alpha-11
v1.0.0-alpha.2 < v1.0.0-alpha.11
from notation-go.
Regarding the versioning conversation from this morning:
To cut a release today, we'd like to propose:
- Notary V2 standard (notaryproject-1.0.0-draft-1)
- Notation Library (Version 0.5.0) (notation-go-lib-1.0.0-alpha-1)
- Notation CLI (Version 0.6.1) (notation-1.0.0-alpha-1)
Becomes - (changing the-
to.
and removing thenotation --version
reference) - Notary V2 standard (notaryproject-1.0.0-draft.1)
- Notation Library (notation-go-lib-1.0.0-alpha.1)
- Notation CLI (notation-1.0.0-alpha.1)
This would apply to
- notaryproject/notaryproject specs
- notaryproject/notation for the cli
- notaryproject/notation-go-lib for the library
from notation-go.
@iamsamirzon @SteveLasker - I believe this is complete now...
All this said - It would be great to discuss release strategy and document something for ongoing work.
from notation-go.
I concur with your David.
from notation-go.
Closed as v0.7.0-alpha.1
has been released.
from notation-go.
Related Issues (20)
- Update `generate-signature` plugin command response data type HOT 1
- Update references from Notary v2 to Notation HOT 1
- Create a bug report template for notation-go HOT 1
- Reducing the PR approval count to 2 HOT 10
- feat: add OCSP revocation checks to Inspect command
- Release v1.0.0-rc.4 for notation-go HOT 2
- Release v1.0.0-rc.4 for notation-go HOT 8
- Error message of errExceededMaxVerificationLimit need to be updated HOT 1
- Vote for release of notation-go v1.0.0-rc.6 HOT 6
- Check the license header for notation-go and its dependencies
- Update the README for the repository
- Support go library based plugins HOT 2
- The notation spec link in annotation is unavailable HOT 1
- Adding plugin examples in notation-go HOT 2
- vote: tag 1.0.0 HOT 6
- oras-go updated v2.3.0
- application/jose+json is not supported HOT 3
- vote: tag 1.0.1 HOT 4
- vote: tag 1.1.0 HOT 7
- Shift Go Support Window to `[1.21, 1.22]` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from notation-go.