Comments (6)
julienw
commented on July 3, 2024
This is not obvious, but cf::CFMutableArrayRef is an alias to *mut libc::c_void.
from notify.
julienw
commented on July 3, 2024
I think we could add unsafe impl Send for FsEventWatcher, as it seems safe to pass this pointer accross threads. Not sure for Sync, but I think it would be fine as well because the methods that change states use &mut self.
What do you think ?
If you agree I can write the patch.
from notify.
passcod
commented on July 3, 2024
Cc @octplane
from notify.
octplane
commented on July 3, 2024
@julienw that would be nice if you could write the patch. Does that only consist in adding the unsafe.. to the impl ? Would you mind trying to write a test for that too ?
from notify.
julienw
commented on July 3, 2024
Yes, it would be simply adding the unsafe impl Send//Sync. I can try to write a test :)
from notify.
octplane
commented on July 3, 2024
Nice 🌅 . Let us know if anything is blocking you.
from notify.
Related Issues (20)
- Consider adding File / Folder to notify::EventKind::Modify HOT 2
- Delete a directory which is watched returns Event { kind: Remove(File) }
- Improve readme and docs with debouncers
- fanotify Support? HOT 8
- Spurious delete event on new file HOT 4
- 100% cpu usage when using notify within tokio library HOT 1
- Watcher isn't Sync with --no-default-features HOT 1
- `bitflags` dependency for macos only?
- Debouncers don't implement Debug HOT 3
- Is there someway to make debounce-watcher be async? HOT 3
- release with bumped `bitflags` and `filetime` version HOT 2
- (even more) license clarifications: non-standard Artistic-2.0 license HOT 6
- Potential Double Free Issue HOT 2
- Use KqueueWatcher as RecommendedWatcher for iOS
- Breaking Changes v7 HOT 7
- notify crate not actually including license text HOT 2
- Catch no events after saving a watching file with Vim editor HOT 1
- How to write unit tests that exercise a watcher? HOT 3
- Filtering out `log` logs HOT 2
- 【with tokio】After executing `git checkout .` command and then modifying the file, unable to get response to file changes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from notify.