Comments (1)
This bug was also affecting ShopifyProductService.ListAsync
and ShopifyProductService.CountAsync
. Fixed it by creating and overriding a Parameterizable.ToSingleParameter
method for both ShopifyOrderFilterOptions
and ShopifyProductFilterOptions
that specifically looks for the Ids
property and converts it to a querystring value when parameterizing.
I was hoping to instead use the property's Type.IsArray
and leave .ToParameters
generic without overrides, but Type.IsArray
wouldn't reliably work on IEnumerable<T>
— only on actual []
arrays.
from shopifysharp.
Related Issues (20)
- OrderListFilter not working as expected HOT 2
- FulfillmentRequestService - Incorrect api request feild name HOT 1
- Error using nuget HOT 4
- FulfillmentOrderService.MoveAsync returns null HOT 4
- PriceRule Property Names Issue HOT 1
- Add appsettings.json support to unit/integration test projects
- Order Service not returning orders from ListAsync HOT 23
- The request for the API is missing properties HOT 5
- FulfillmentService.CreateAsync has been returning an error 404 HOT 3
- Deprecation notice: intent to remove ShopifySharp's DefaultHttpClientFactory
- Add release notes to Nuget package
- Payment Details HOT 2
- How Can I Add New Shipping method HOT 2
- PONumber in Order object HOT 4
- Unable to set Product Variant Images HOT 2
- Use Postgresql or Mysql/MariaDB HOT 2
- Order GetList Filter PageInfo only get,why not set? HOT 3
- Adding new SKU to Shopify adds to 2 zeros. HOT 2
- How to get more than 250 Products in Product Service HOT 2
- Fulfillments HOT 22
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shopifysharp.