Properly reverse-engineer non-SERIAL sequences

[npgsql]

Properly reverse-engineer non-SERIAL sequences

[roji]

From @pantonis on March 4, 2016 18:59

Hi,

entity.Property(e => e.IDFactura) .HasDefaultValueSql("nextval('\"Factura_FacturaID_seq\"'::regclass)") .ValueGeneratedNever();

should be:

entity.Property(e => e.IDFactura) .HasDefaultValueSql("nextval('\"Factura_FacturaID_seq\"'::regclass)") .ValueGeneratedOnAdd();

Had the same problem. Think when the reverse engineer tool creates the context it creates ValueGeneratedNever(); instead of ValueGeneratedOnAdd();.

This is a pain because every time I update my context I have to go and update everything manually.

[roji]

From @angelcalvasp on March 17, 2016 20:17

thanks for the workaaround,maybe this should be fixed?, a bug maybe?

[roji]

@angelcalvasp, @pantonis, the Npgsql EFCore provider has logic to identify serial columns and reverse-engineer them properly. It seems this logic doesn't pick up your column because of naming issues: your database column appear to be called IDFactura, while the sequence associated to the column is called Factura_FacturaID_seq (note the ID coming after Factura). This probably means you manually named your column or sequence.

In any case, this is a bug - the provider should be able to handle this. Can you please just confirm how exactly you create your schema?

[roji]

Waiting on dotnet/efcore#5366

[im1dermike]

In your calling of nextval(), it looks like you're passing in parameters. Is that the case? I'm attempting to use HasDefaultValueSql() to set a property on my model when on INSERT, but I would need to pass a parameter to my function.

[roji]

@im1dermike, whatever you pass as the argument to HasDefaultValueSql() will be set on your PostgreSQL column definition, as-is - you can put any valid PostgreSQL expression. However, that expression can't be parameterized - it's set just once when creating the column (parameterizing it would make no real sense). The placeholders you see in the expression nextval('{tableName}_{columnName}_seq'::regclass) are simple C# parameters to set the table and column names.

If you need more info, try to explain your scenario and why you think you need parameterization.