Comments (7)
AFAICT the linter is running successfully:
2021-03-30 21:34:10 [NOTICE] All file(s) linted successfully with no errors detected
Where are you seeing the failure?
from nsrdb.
Whoops, forgot the linter only looks at "changed" files, here is the old one:
https://github.com/NREL/nsrdb/runs/2230183820?check_suite_focus=true
from nsrdb.
I see them now. Man, both eagle vim and pylint seem to really dislike f-strings. Looks like there are some arguments against using f-strings with logging, see pylint-dev/pylint#2395. Performance seems about nill for us, especially considering how IO bound the nsrdb code is. What's your take?
from nsrdb.
I honestly dont feel strongly about fstrings. I would be fine having them in our code bases. I think we're already not following best practices for logging strings as Dan had pointed out to us previously.
from nsrdb.
Fine by me, I'll add that to the pylint file to exclude.
from nsrdb.
okay push this to the branch, Mike I can't remember if there are any other pylint errors in albedo, but feel free to close this once you can get pylint to pass
from nsrdb.
Passing
from nsrdb.
Related Issues (20)
- Data model output files to temp scratch then move HOT 8
- Sanity check nsrdb time series frequency HOT 2
- Add docker file and docker compose for lambda HOT 2
- Remove pyhdf dependence HOT 3
- Pull 5 year average aerosols for Puerto Rico data HOT 1
- Add glob utility for data model filepath spec HOT 1
- Code chunk meta/coords HOT 5
- Generate coordinates dataset for final NSRDB output HOT 4
- NSRDB Meta Data NaN values and Dtypes HOT 2
- Change AOD physical limits HOT 6
- os.path.basename nan handling HOT 1
- additonal flags for cli HOT 2
- "Shark's teeth" artifacts in composite albedo data HOT 2
- NSRDB pipeline single job debug HOT 2
- MERRA Data Interpolation Bug HOT 3
- Missing import in nsrdb/all_sky/__init__.py? HOT 1
- Failed IMS data download for Albedo module
- Automatic modis download
- incorrect logic in collection?
- Pandas v1 compatibility HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nsrdb.