Giter Site home page Giter Site logo

_sentQueue leaks about sofie-atem-connection HOT 2 CLOSED

nrkno avatar nrkno commented on September 25, 2024
_sentQueue leaks

from sofie-atem-connection.

Comments (2)

mint-dewit avatar mint-dewit commented on September 25, 2024

Disconnect before ack implies we will timeout in the socket class, thus rejecting the promise (I think)

Rejecting any sent commands should definitely remove them from the queue though.

from sofie-atem-connection.

Julusian avatar Julusian commented on September 25, 2024

Disconnect before ack implies we will timeout in the socket class, thus rejecting the promise (I think)

Going deeper that raises more concerns. Such as retransmits continuing across calls to connect/disconnect.

Ill try and find some time to confirm this, and look at writing some tests for the packet sending/handling logic

from sofie-atem-connection.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.